fretboard.js icon indicating copy to clipboard operation
fretboard.js copied to clipboard

Minor CAGED boxes out by one position

Open Aduffy opened this issue 4 years ago • 7 comments

If I render an A Minor scale with CAGED G shape box, it renders the E shape box.

image

https://codepen.io/aduffy/pen/dypvjKa

Aduffy avatar Feb 05 '21 07:02 Aduffy

This is by design - you are actually getting C major in the G-CAGED box, whose relative minor is Am.

I assume the CAGED system to be major based also - shapes like C minor (in the C box) are simply unplayable, at least not barre-movable!

As always, I don't think it is helpful to "be able to play the Am scale in the G shape", but to expand one's fretboard knowledge!

moonwave99 avatar Feb 05 '21 12:02 moonwave99

I hear you and do get where your coming from, and although most of whats out there for CAGED is based on the Major shapes, there are a few sites that teach a Minor based CAGED structure and those that do, seem to agree on the structure/naming..

https://appliedguitartheory.com/lessons/minor-caged-system/ https://www.guitarlessons.com/guitar-lessons/exercises-and-fretboard-navigation/caged-minor-guitar-chords https://www.guitartutoronline.com/advanced/scales-caged-system/minor-caged-system-theory#e-shape

I do see the logic and value of having only one pattern having the name "G Shape" vs the "Major G Shape" and a "Minor G Shape". but if a person where to just look at this screen shot I posted and you tell them its a "G Shape" thats really confusing since you can clearly see that the 1,5,m3,1.5 notes clearly define a "E Minor" Chord....

I know this is a bit of a Mac VS PC / Nikon Vs Canon / sort of debate and there are defenitly 2 schools of thought that both have there validations..

For me Im wanting to base my naming on what I find is the most common methods for teaching i can find on line.

Im more than happy to make adjustments in my code if you are firmly in the "1 G Shape" camp. :-)

Cheers, and thanks again for your hard work on this Library!

Aduffy avatar Feb 05 '21 18:02 Aduffy

That the whole point of the library was to make a tool that helped me get rid of this systems, because they are very satisfying for diagram lovers, but not for musicians (at least not for me!).

I implemented some box systems though, as showcase and for personal challenge.

If there was an easy way to implement a clear interface that let choose between the two options, I would be more than happy to work on that! But I am afraid it would just make things more complex.

Thanks again for your input by the way, much appreciated and it really helped me in going forward with the work, cheers!

moonwave99 avatar Feb 05 '21 22:02 moonwave99

Ya the more i dig i find more naming conventions and even modified patterns (half 3NPS half Penatonic? ) ... I think i might consider making a user preference option on the site im working on to let he user pick the model they prefer .. but then that requires a long winded explanation of the differences... Hmm

Aduffy avatar Feb 06 '21 20:02 Aduffy

Btw easy fix - the boxes are hardcoded, so you can easily implement your CAGEDMinor system by flattening the opportune degrees, and render accordingly!

moonwave99 avatar Feb 07 '21 15:02 moonwave99

Hey Diego, just circling back to the project i was using this on last winter... Wondering if you would consider officially implementing CAGEDMinor feature akin to the PenatonicMinor that you added already.. Id be happy to "Sponsor" said update if you would be wiling.

Cheers hope you are doing well!

Aduffy avatar Sep 05 '21 04:09 Aduffy

Hey @Aduffy how are you!

I don't think I will have time for this any soon :.

What you can do, is explore how I am defining / using the fretboard systems: it shouldn't be difficult to create the missing CAGEDMinor system!

(Cm and Gm shapes are a hard stretch btw!)

moonwave99 avatar Sep 15 '21 07:09 moonwave99