moon icon indicating copy to clipboard operation
moon copied to clipboard

Add Shebang to packages/cli/moon to Resolve Exec Format Error on Linux

Open reoring opened this issue 10 months ago • 3 comments

After cloning the moonrepo repository, I noticed that the contents of packages/cli/moon are in plain text and do not include a shebang line. This absence leads to an "Exec format error (os error 8)" when trying to execute the script on Linux, making it difficult to understand the error.

However, the script merely outputs text when run on macOS. To address this issue and clarify the script's purpose across different operating systems, I have added a shebang line to the script.

reoring avatar Apr 17 '24 02:04 reoring

@reoring What are you trying to do exactly?

This file gets replaced by package managers when the package is installed, but should never be executed by end users. If you're trying to run moon in the repo itself, we suggest using cargo run.

milesj avatar Apr 17 '24 02:04 milesj

Hi @milesj,

Thank you for your prompt response and for clarifying how the script is handled during installation. Based on your advice, I understand that running cargo run is the recommended approach for developers looking to run moon directly from the repository.

Considering this, I propose adding a note or message in directly within the script. This would serve as a helpful guide for new developers, ensuring they use cargo run and understand the workflow more quickly. It could potentially prevent any confusion for those who might try to execute the script directly.

I believe this small addition could significantly enhance the onboarding experience for new contributors. Let me know what you think!

Best regards,

reoring avatar Apr 17 '24 02:04 reoring

@reoring Change looks good, just need to update scripts/checks/cliBinary.sh.

You can ignore the version check error.

milesj avatar Apr 17 '24 17:04 milesj

Gonna close this since this PR actually fixes this indirectly https://github.com/moonrepo/moon/pull/1472

milesj avatar May 19 '24 00:05 milesj