moon icon indicating copy to clipboard operation
moon copied to clipboard

[feature] PHP tier 2

Open andrejbaran opened this issue 2 years ago • 4 comments
trafficstars

Is your feature request related to a problem? Please describe.

Hey 👋

I was wondering what are the plans for tier 2 integration of PHP/Composer. Is it something you guys would accept as PR?

Describe the solution you'd like

I would love to use moon for PHP projects

Describe alternatives you've considered

There are only a handful of attempts and all are PHP specific

Additional context

andrejbaran avatar Nov 21 '23 13:11 andrejbaran

@andrejbaran We're pausing new language work for the time being until we move to a new WASM plugin based approach. Having all the languages in the core Rust codebase has become a bit of a maintenance burden. We're aiming for moon v2 for the plugin system.

With that said, there are a few things:

  • You can definitely run php/composer commands from moon, you would just lose the extra "moon functionality". https://moonrepo.dev/docs/cheat-sheet#run-language-binaries-not-supported-in-moons-toolchain
  • The future WASM plugins will be partially powered by proto plugins, so you could start working on a PHP proto plugin today. https://moonrepo.dev/docs/proto/wasm-plugin

milesj avatar Nov 21 '23 20:11 milesj

  • You can definitely run php/composer commands from moon, you would just lose the extra "moon functionality". https://moonrepo.dev/docs/cheat-sheet#run-language-binaries-not-supported-in-moons-toolchain

Yup, that extra is what I was aiming for :)

  • The future WASM plugins will be partially powered by proto plugins, so you could start working on a PHP proto plugin today. https://moonrepo.dev/docs/proto/wasm-plugin

I kind of sensed that direction from somewhere in the codebase (maybe the 1.17 PR, not sure right now). Anyway, sounds great so I will try to find the time, checkout available plugins and go for it.

Thanks!

andrejbaran avatar Nov 21 '23 21:11 andrejbaran

If you plan on creating a WASM plugin, feel free to join in Discord and we can discuss!

PHP is a bit unique compared to the others, as you'll have to toggle extra features during build like mysql/etc. We'll need to figure out how to best handle that.

milesj avatar Nov 21 '23 23:11 milesj

If you plan on creating a WASM plugin, feel free to join in Discord and we can discuss!

👍 will do

PHP is a bit unique compared to the others, as you'll have to toggle extra features during build like mysql/etc. We'll need to figure out how to best handle that.

Unfortunately, it is. I thought proto wasn't ready for building yet as mentioned in the roadmap but let's discuss in Discord

andrejbaran avatar Nov 22 '23 07:11 andrejbaran