node-ntp-client icon indicating copy to clipboard operation
node-ntp-client copied to clipboard

Passing string as error to callback

Open tacticalchihuahua opened this issue 8 years ago • 0 comments

If the dgram client errors, the callback receives an Error object, but if there is a timeout a String gets passed as the error callback which makes appropriate error handling a real pain:

https://github.com/moonpyk/node-ntp-client/blob/master/lib/ntp-client.js#L52

tacticalchihuahua avatar Aug 25 '16 14:08 tacticalchihuahua