core Add `FixedArray::unsafe_get`, `FixedArray::unsafe

Oct 12 '24 09:10 tonyfettes

From the provided git diff output, here are three potential issues or suggestions for improvement:

Redundant Implementations:
- The git diff shows that both op_get and get are defined for FixedArray. Typically, op_get is the operator overload for the [] operator, and get might be a convenience method. However, having both can be redundant unless there is a specific reason for differentiation. If they perform the same operation, consider consolidating them to avoid confusion and maintainability issues.
```
-pub fn FixedArray::op_get[T](self : FixedArray[T], idx : Int) -> T = "%fixedarray.get"
-pub fn FixedArray::get[T](self : FixedArray[T], idx : Int) -> T = "%fixedarray.get"
```
Unsafe Methods Naming Conventions:
- The introduction of unsafe_get and unsafe_set methods suggests that these operations bypass safety checks. It's crucial to ensure that the naming convention clearly indicates the unsafe nature of these operations to prevent accidental usage. Additionally, consider documenting the potential risks associated with these methods to warn developers.
```
/// @alert unsafe "This method bypasses bounds checking. Ensure the index is valid to avoid runtime errors."
pub fn FixedArray::unsafe_get[T](self : FixedArray[T], idx : Int) -> T = "%fixedarray.unsafe_get"
```
Consistency in Method Definitions:
- When defining methods like unsafe_set, ensure consistency in the formatting and spacing for better readability. The provided git diff shows a slight inconsistency in how unsafe_set is formatted compared to other method definitions.
```
-pub fn FixedArray::unsafe_set[T](
-  self : FixedArray[T],
-  idx : Int,
-  val : T
-) -> Unit = "%fixedarray.unsafe_set"
+pub fn FixedArray::unsafe_set[T](self : FixedArray[T], idx : Int, val : T) -> Unit = "%fixedarray.unsafe_set"
```
Keeping the method definitions consistently formatted can enhance code readability and maintainability.