ci: native backend test on windows
Based on the provided git diff output, here are three observations and suggestions for potential issues:
-
Unusual
ulimitSetting in GitHub Workflow:- name: moon test in native backend (unix) if: ${{ matrix.os != 'windows-latest' }} run: | ulimit -s 8176 moon test --target native moon test --target native --releaseSuggestion: The
ulimit -s 8176command sets the stack size limit to 8176 KB, which is quite specific. Ensure that this value is necessary and appropriate for the tests being run. If not, consider reverting to the default or a more standard value to avoid potential issues with memory usage. -
Inconsistent Release Support for Windows in GitHub Workflow:
- name: moon test in native backend (windows) if: ${{ matrix.os == 'windows-latest' }} run: | # --release not support for windows moon test --target native --dry-run moon test --target nativeSuggestion: The comment
# --release not support for windowssuggests that running tests in release mode is not supported on Windows. This inconsistency could lead to differences in behavior between platforms. Consider investigating why release mode is not supported on Windows and either address the issue or document it clearly to avoid confusion. -
Modification to
moon.mod.json:{ "readme": "README.md", "repository": "https://github.com/moonbitlang/core", "license": "Apache-2.0", "keywords": ["core","standard library"], "link-flags": ["-cc", "cl /nologo"] }Suggestion: The addition of
"link-flags": ["-cc", "cl /nologo"]inmoon.mod.jsonindicates a change in compilation settings. Ensure that these flags are necessary and correctly configured for the build process. Specifically, verify thatcl /nologois appropriate for the intended compiler and that it does not introduce any unintended side effects or compatibility issues.
These suggestions aim to address potential issues related to resource management, platform consistency, and build configuration, ensuring a smoother development and testing workflow.
Pull Request Test Coverage Report for Build 4146
Details
- 0 of 0 changed or added relevant lines in 0 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage remained the same at 80.838%
| Totals | |
|---|---|
| Change from base Build 4142: | 0.0% |
| Covered Lines: | 4493 |
| Relevant Lines: | 5558 |
💛 - Coveralls
@Young-Flash is this PR still relevant?