moonbeam icon indicating copy to clipboard operation
moonbeam copied to clipboard

Add XcmPayment runtime API

Open Agusrodri opened this issue 1 year ago • 1 comments

Agusrodri avatar Jul 01 '24 22:07 Agusrodri

Coverage Report

@@                     Coverage Diff                     @@
##           master   agustin-xcm-payment-api      +/-   ##
===========================================================
+ Coverage   81.10%                    81.26%   +0.16%     
+ Files         274                       301      +27     
+ Lines       80576                     85781    +5205     
===========================================================
+ Hits        65348                     69704    +4356     
+ Misses      15228                     16077     +849     
Files Changed Coverage
/client/rpc/finality/src/lib.rs 95.92% (+7.78%) 🔼
/pallets/parachain-staking/src/lib.rs 91.73% (-0.01%) 🔽
/pallets/parachain-staking/src/mock.rs 97.65% (+0.02%) 🔼
/pallets/parachain-staking/src/tests.rs 91.39% (+0.03%) 🔼
/precompiles/xcm-transactor/src/v1/mod.rs 87.95% (+0.45%) 🔼
/precompiles/xcm-transactor/src/v2/mod.rs 76.42% (-2.22%) 🔽
/precompiles/xcm-transactor/src/v3/mod.rs 83.33% (-2.26%) 🔽
/precompiles/xcm-utils/src/lib.rs 90.98% (-0.69%) 🔽
/runtime/common/src/apis.rs 28.40% (-2.12%) 🔽

Coverage generated Wed Jul 10 22:13:43 UTC 2024

github-actions[bot] avatar Jul 01 '24 23:07 github-actions[bot]

About the test, could we use the fees calculated and do an xcm call to make sure the estimated value is enough?

RomarQ avatar Jul 05 '24 06:07 RomarQ

About the test, could we use the fees calculated and do an xcm call to make sure the estimated value is enough?

@RomarQ I just added two tests (one for native fees and another one for foreign fees) in 391b6368a6c87c16fafc58ff645584dac7467b0c :)

Agusrodri avatar Jul 10 '24 21:07 Agusrodri