moonbeam icon indicating copy to clipboard operation
moonbeam copied to clipboard

Suggestion: Move precompile-utils to Frontier

Open intendednull opened this issue 2 years ago • 8 comments

We're developing precompiles over at Humanode, and have found your utility crate to be super helpful!

Would it be possible to find a new home for it, like Frontier? If not, what are the obstacle preventing it from wider use?

We're willing to make the move ourselves if necessary. Thank you!

intendednull avatar Jun 27 '22 22:06 intendednull

Hey! That's indeed something we already thought about doing. However we are still regularily making changes to it, and having it in our repo allows us to iterate faster. Once it is more stable and need less changes we'll suggest moving it into Frontier :)

nanocryk avatar Jun 28 '22 13:06 nanocryk

@nanocryk Hi, any process about this? The latest procedural-macro implementation is fantastic.

boundless-forest avatar Nov 21 '22 03:11 boundless-forest

Started to work on it but there are a few pending PRs to improve the crate, and a few more feature we need to work on. Afterward I'll resume the work of migrating it to Frontier, or to move them in their dedicated repo.

nanocryk avatar Jan 30 '23 13:01 nanocryk

@nanocryk Are there any other pending PRs that need to be processed after merging #2095? Maybe we can start the migration work if nothing else works, maybe I can help?

koushiro avatar Feb 13 '23 16:02 koushiro

@koushiro I'd like to add macro UI tests for precompile_name_from_address as they are some typos in the macro that gives bad error messages when used incorrectly. I'd also like to refactor a bit the crate and add more documentation, but we can probably do that when migrating it in frontier to only do a single pass of changes in the moonbeam repo :p

After that it would be interesting to have feedback on the global design of the crate, what is too Moonbeam-specific, what should be cleaned up, etc.

Feel free to start reviewing the crate and provide feedback in this issue :)

nanocryk avatar Feb 15 '23 10:02 nanocryk

I started a cleanup refactor of the precompile-utils crate here: https://github.com/PureStake/moonbeam/pull/2165

Could I have your feedback @koushiro ? :)

nanocryk avatar Mar 17 '23 10:03 nanocryk

Great news that #2165 is merged now! Is there any update on actual frontier migration though? I'd appreciate a link to a tracking issue if there is one somewhere...

MOZGIII avatar Jun 30 '23 01:06 MOZGIII

@MOZGIII https://github.com/paritytech/frontier/pull/1150

ashutoshvarma avatar Aug 18 '23 05:08 ashutoshvarma