moonbeam icon indicating copy to clipboard operation
moonbeam copied to clipboard

Published 20 hours ago • verified publisher icon moonbeam-foundation

Tracing targets disappeared in runtime 1502

Open perltk45 opened this issue 3 years ago • 7 comments

If we pass "--tracing-targets author-filter=debug" parameter client v0.23.0 on moonbeam results in log entries like this: 2022-05-13 16:14:44.6413 moonbeam[528905]: 2022-05-13 16:14:44.601 DEBUG tokio-runtime-worker author-filter: [🌗] Eligible Authors: [0xba360f50eb4b68f384c5d4ee4fd1bfbe50d5208b] 2022-05-13 16:14:44.6413 moonbeam[528905]: 2022-05-13 16:14:44.601 DEBUG tokio-runtime-worker author-filter: [🌗] Ineligible Authors: [0x0198d3053a69c3f977bb1943bc95a0ffa7777474, 0x01bb6ce8b88f09a7d0bfb40eff7f2ad5e0df2e98, 0x0663aa7beb6a9229fc5a016ffc81c0f133442a54...]

However, the same parameter passed to the same version of client on moonriver does NOT result in DEBUG tokio-runtime-worker author-filter:..." log entries.

Was this intentional that runtime 1502 removes these log entries? (Note, this used to work on moonriver in client version 22)

perltk45 avatar May 13 '22 23:05 perltk45

@perltk45, I've never used the --tracing-targets parameter, I usually rely on the --log, have you tried it ? @librelois, any idea what would this happen ?

crystalin avatar May 14 '22 00:05 crystalin

Yes, "--log author-filter=debug" should work and I've used it before, but it no longer works. To be clear, it doesn't work on Moonriver, but it does still work on Moonbeam.

perltk45 avatar May 14 '22 00:05 perltk45

@librelois I think it is related to the compilation feature you added to the publish runtime flow

crystalin avatar May 14 '22 00:05 crystalin

@perltk45 The runtime is taken from on-chain, so you can't control it (there is the possibility to override it, but it is a bit complex)

crystalin avatar May 14 '22 01:05 crystalin

Yes, since this PR the on-chain runtime does not contain any logs: https://github.com/PureStake/moonbeam/pull/1441

the goal is to reduce the size of the runtime bytecode stored in the onchain storage. To have the logs anyway, we have to provide a runtime override in the moonbeam image and automatically activate it.

You can also decide to put the logs back in the on-chain runtime if the gain in code size is negligible.

librelois avatar May 16 '22 10:05 librelois

@librelois Considering the wasm bytecode size wasn't different from the previous ones:

1223302 moonriver-runtime-1401.wasm
1231005 moonriver-runtime-1502.wasm

I think we should restore the logs (they are useful for collators)

crystalin avatar May 16 '22 12:05 crystalin

the wasm bytecode size wasn't different from the previous ones:

Ok, so it's not worth it, I revert: https://github.com/PureStake/moonbeam/pull/1513

librelois avatar May 16 '22 12:05 librelois