minible icon indicating copy to clipboard operation
minible copied to clipboard

Query the time whenever TOTP is requested

Open bertvandepoel opened this issue 2 years ago • 16 comments

Currently, there are cases when the miniBLE hasn't synced yet by the time a TOTP response is requested. This results in login errors. The temporary fix is to restart moolticute. As discussed on IRC, there are several solutions, but the easiest would be if the miniBLE requested the time from moolticute (or e.g. the future android companion) every time a TOTP response is requested.

bertvandepoel avatar Nov 30 '21 01:11 bertvandepoel

I also have much trouble getting correct TOTP's from the miniBLE. The miniBLE is always on (or in stndby) cennected to my PC, but the clock seems to have such a massive drift that after 3 days the TOTP doesn't work. Also there should be an option to force the miniBLE (doens't realy matter if on the minible or in the app) to get the current time.

Please fix that in near time, it's an awesome feature but realy annoying if it doesn't works.

Jan-NiklasB avatar Dec 17 '21 14:12 Jan-NiklasB

Just so you know, @Jan-NiklasB, a good workaround in the mean time is to select "restart daemon" in the tray menu item of moolticute. That forces a clock sync and resolves the issue at that time. I'm quite sure limpkin has this issue earmarked as quite relevant for firmware updates, so hopefully this will be fixed permanently in the near future.

bertvandepoel avatar Dec 17 '21 14:12 bertvandepoel

Ah, good to know, thanks for the hint. Yeah I guess so, also the support on my order was incredible fast, so I guess this is also a project of heart for him.

Jan-NiklasB avatar Dec 17 '21 15:12 Jan-NiklasB

Another option would be to poll the Bluetooth Time service on the paired device.

rastagraffix avatar Jan 16 '22 02:01 rastagraffix

@rastagraffix do you mean the host? I'm fairly sure the host doesn't expose such a service :)

limpkin avatar Jan 16 '22 07:01 limpkin

All my Apple devices support the standard Time service, although they don't advertise it or allow connections to it over BLE unless you're a paired and connected device. I'm currently working out the logistics of this on the Watchy; it's a much lower power alternative to the current SNTP over Wifi scheme they use.

rastagraffix avatar Jan 16 '22 09:01 rastagraffix

To0 be clearer, not every device you connect to will support the Time service. But if you're already connected to a device to do TOTP, it doesn't cost anything to see if GATT advertises the standard Time service and, if it does, connect to that and sync the time.

In theory this should work if you're connected to any iOS, iPadOS, or MacOS device.

rastagraffix avatar Jan 16 '22 09:01 rastagraffix

oh that's quite interesting!

limpkin avatar Jan 16 '22 09:01 limpkin

@bertvandepoel I'm currently looking into this one but I can't verify your initial statement:

Currently, there are cases when the miniBLE hasn't synced yet by the time a TOTP response is requested.

On my setup, whenever a Mini BLE is connected, Moolticute will send the local time. Moreover, MC will regularly send the time to the Mini BLE so it can calibrate itself :)

limpkin avatar Apr 03 '22 09:04 limpkin

Oh weird, I thought you had already fixed this! A while ago this problem just went away for me and I've never seen it since. So some firmware or moolticute change seems to have rectified it, I think. But I'm not sure what exactly was the cause for the problem nor the fix.

bertvandepoel avatar Apr 03 '22 10:04 bertvandepoel

oh neat! should i close the issue then? :)

limpkin avatar Apr 03 '22 10:04 limpkin

Let's maybe see if @Jan-NiklasB responds? Maybe he still has the issue. But if he doesn't (or doesn't respond), I would indeed suggest we close it.

bertvandepoel avatar Apr 03 '22 10:04 bertvandepoel

Hey, to be honest I have to check this. I don't really use the minible for TOTP since its easier for me to use andotp on my phone than scrolling through the whole list of credentials to get the totp....

Maybe if totp entering is part of the auto login it would become more relevant to me. ..

Am 3. April 2022 12:26:50 MESZ schrieb Bert Van de Poel @.***>:

Let's maybe see if @Jan-NiklasB responds? Maybe he still has the issue. But if he doesn't (or doesn't respond), I would indeed suggest we close it.

-- Reply to this email directly or view it on GitHub: https://github.com/mooltipass/minible/issues/310#issuecomment-1086831459 You are receiving this because you were mentioned.

Message ID: @.***> -- Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.

Jan-NiklasB avatar Apr 03 '22 14:04 Jan-NiklasB

@Jan-NiklasB we've recently added firmware features to make the TOTP experience way better... stay tuned for bundle v9 release :)

limpkin avatar Apr 03 '22 15:04 limpkin

Now you have my attention 😂

Am 3. April 2022 17:03:43 MESZ schrieb Mathieu @.>: @. we've recently added firmware features to make the TOTP experience way better... stay tuned for bundle v9 release :)

-- Reply to this email directly or view it on GitHub: https://github.com/mooltipass/minible/issues/310#issuecomment-1086887180 You are receiving this because you were mentioned.

Message ID: @.***> -- Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.

Jan-NiklasB avatar Apr 03 '22 16:04 Jan-NiklasB

hello everyone! bundle v12 is available at beta-updates.themooltipass.com . Could you update your devices and let me know if this is still an issue? :)

limpkin avatar Nov 05 '22 11:11 limpkin