PyTrakt

PyTrakt copied to clipboard

[python-pytrakt] Cleanup: Drop classes extending from object

1

This is not needed for Python3 as the "old style" classes don't exist and inheritance from object is implicit. - https://stackoverflow.com/questions/15374857/should-all-python-classes-extend-object - http://docs.python.org/release/2.5.2/ref/node33.html

glensc

get_watched returns watchlist instead of watchED list

5

panosk75

[python-trakt] Add deprecation notice for sync.get_watched

1

Requires (must be merged first): - https://github.com/moogar0880/PyTrakt/pull/173 Deprecate method behaving incorrectly: https://github.com/moogar0880/PyTrakt/issues/160 ``` ➜ python -c "import trakt.sync; print(trakt.sync.get_watched())" :1: DeprecationWarning: Call to deprecated function (or staticmethod) get_watched. (This method...

glensc

No need to rename `get` method to `_get`. This might have been an issue in older Python (2.x?) This restores original symbol and for not to break API, the _get...

glensc

[python-pytrakt] Feature: Return responses of Scrobble methods

2

This allows applications to do something with the responses. Docs: - https://trakt.docs.apiary.io/#reference/scrobble/start - https://trakt.docs.apiary.io/#reference/scrobble/pause - https://trakt.docs.apiary.io/#reference/scrobble/stop Needed by: - https://github.com/Taxel/PlexTraktSync/pull/761

glensc

[python-pytrakt] Cleanup: Drop api_key (deprecated in 2.x)

1

glensc

[python-pytrakt] Feature: Throw BadResponseException on JSON decode errors

4

Many `JSONDecodeError` (from json module) are actually thrown because trakt.tv site responds with a status code that is not yet recognized by this library: - https://github.com/Taxel/PlexTraktSync/issues?q=label%3A%22trakt+support%22+sort%3Aupdated-desc+is%3Aclosed+JSONDecodeError Add fallback logic to...

glensc

[python-pytrakt] Feature: Add User.get_liked_lists method

6

This is to carry methods to this library: - https://github.com/Taxel/PlexTraktSync/blob/b777508eb4a8b44aa2559e9b5b5c6f9be16c19e0/plextraktsync/pytrakt_extensions.py#L5-L14

glensc

[python-pytrakt] Cleanup: __iter__ doesn't take any args

1

glensc

[python-pytrakt] Privacy: Don't log headers to protect privacy

4

Scenario, where need to really debug HTTP headers, are perhaps when developing this library. This is never useful for end-users and could cause leaking the tokens when sharing logs: refs:...

glensc