Moody Salem

Results 100 comments of Moody Salem

I'm ok with not having this, I realize it's not quite as important to optimize storage reads on Starknet. But it would be nice to be able to mark a...

> Will `u8` be enough for offset representation? In most cases yes, but what if we have to read/write something really long? `u16` or `u32` may work better for offsets...

now that infura has a working websocket endpoint this is higher priority imo deploying to mainnet without websockets via infura is a huge pain because they use a load balancer

maybe for the `@uniswap/governance-seatbelt` npm package we also export code for rendering and implement one for markdown e.g. ```typescript interface Renderer { render(result: SimulationResult): T } class MarkdownRenderer implements Renderer...

is this a difference between v3-core and v3-core-optimism or the code is the same b/t the two?

It seems like all that is needed is to add a value to the enum, but since it can be any network ID it might be better to support a...

I've refactored the code to use `ChainId | number` everywhere which only fails if you are trying to swap to/from the `Currency.ETHER` constant (because of how we map between WETH9/Ether)...

> @moodysalem is this version available in https://www.npmjs.com/package/@uniswap/sdk? No, the package is now `@uniswap/v2-sdk` for consistency with core and periphery But you might also be blocked by https://github.com/Uniswap/uniswap-v2-sdk/issues/55

or ideally add a watch mode that only runs the changed tests and i can just fix my tests in real time

it takes 45 seconds just to compile so i can run a single test in the ekubo contracts repo right now. i'm used to it but this feels very high...