Antoine Fabri

Results 157 comments of Antoine Fabri

This might indeed be due to {dbplyr} translating differently. locally I have : ``` SELECT "grp", (SELECT "a_i", "a_j" FROM "remote" WHERE ("grp" = "q01"."grp") FOR JSON PATH) AS "A"...

@krlmlr I think we could make the dbplyr code look much better if we allow the SQL code to look a little less good, would the following query be acceptable...

Do we need code that works for both current cran and new {dbplyr} ? I could tweak the code to make it work with more string manipulation but I don't...

* `json_nest.tbl_Microsoft SQL Server` now uses `sql_render()` rather than assuming it's passed an existing table * It handles the `.names_sep` arg * The code is restructured so subqueries and different...

> Tests are brittle, see https://github.com/cynkra/dm/pull/1445/files and https://github.com/cynkra/dm/pull/1444/files . How can we stabilize? On Postgres it seems we have time dependent aliases, I tried `gsub("test_frame_[_0-9]+", "test_frame_...", query)` to get a...

@krlmlr It's all green except for codecov/patch, should I add more tests ?

@krlmlr given that `dm_apply_filters()` is deprecated, should it be modified to get the feature ? It would be small work but not sure if it's good practice to update a...

Yes diagrams before and after would help a lot, this is something the help files don't (can't ?) provide and is so much easier to understand than abstract text. With...