moodle-local_moodlecheck icon indicating copy to clipboard operation
moodle-local_moodlecheck copied to clipboard

Published 20 hours ago • verified publisher icon moodlehq

Can this be converted to sniffs for PHP_CodeSniffer?

Open polothy opened this issue 8 years ago • 5 comments

With PHP_CodeSniffer 2.0, I believe they have greatly improved their tokenizing of PHPDoc blocks. Would it now be possible to fold this into local_codechecker's PHP_CodeSniffer code standard?

polothy avatar Dec 18 '15 18:12 polothy

+100 if we can do this - helps with IDE integration etc etc (finding someone who can do the work might be more difficult)

danpoltawski avatar Dec 18 '15 19:12 danpoltawski

Just leaving this here, it must be completed before something like this could be attempted: https://tracker.moodle.org/browse/CONTRIB-5732

polothy avatar Dec 18 '15 21:12 polothy

For reference, link to (2y old) issue where a research about this was performed.

https://tracker.moodle.org/browse/CONTRIB-4165 (not saying we cannot re-evaluate the situation, just adding the reference)

stronk7 avatar Jun 08 '16 20:06 stronk7

Just been thinking about this and wondering.. if we could disable all the 'dumb' rules in this plugin which can be replaced by sniffs. Then just leave the more intelligent checks here if they can't be replaced. It's not perfect, but I think it's advantageous to do the move because of tooling support.

danpoltawski avatar Sep 08 '16 12:09 danpoltawski