moodle-local_codechecker icon indicating copy to clipboard operation
moodle-local_codechecker copied to clipboard

Published 20 hours ago • verified publisher icon moodlehq

Compatibility with PHP 8.1

Open marinaglancy opened this issue 2 years ago • 3 comments

marinaglancy avatar Jul 11 '22 14:07 marinaglancy

Hi @marinaglancy , would you mind rebasing this (now that we have completed the transition to moodle-cs and everything is now in place). Just to verify if we get a pass with the GHA jobs.

Ciao :-)

stronk7 avatar Sep 21 '22 08:09 stronk7

Hi @marinaglancy , I've proceeded to rebase your branch on top of current master, let's see how it ends (GHA-wise).

Ciao :-)

stronk7 avatar Sep 30 '22 10:09 stronk7

BTW, I've just checked and those changes (or similar) aren't upstream, so maybe we should report them or reproduce how they are happening to see if they are fixed elsewhere (in some caller, higher level or so...).

It's strange they have not fixed them but we need to do so... uhm...

Ciao :-)

stronk7 avatar Sep 30 '22 10:09 stronk7

Closing this as won't fix because in #221 we are moving to Composer based installation of dependencies. So this cannot be fixed locally anymore.

stronk7 avatar Sep 25 '23 09:09 stronk7