moodle-docker icon indicating copy to clipboard operation
moodle-docker copied to clipboard

Set the path to python

Open dmonllao opened this issue 6 years ago • 6 comments

dmonllao avatar Dec 10 '18 10:12 dmonllao

Thanks for commenting Matteo. I've applied the suggested change.

To be honest, I've always seen paths to binaries specified using the full path, but I have never understood what is the advantage of it over just using the file name. I do understand that the difference when the script using just the bin file name does not know the system where it will be executed, but in this case we do.

dmonllao avatar Dec 10 '18 16:12 dmonllao

TNX @dmonllao! Using the absolute path is cleaner (IMHO), safer - the main reason, even if running in a container where layers are known - and quicker; otherwise, the system will look up in what defined in an environment variable called PATH following its ordering, being the env defined by that user context.

HTH, Matteo

scara avatar Dec 10 '18 21:12 scara

:+1: to full path

danpoltawski avatar Dec 11 '18 09:12 danpoltawski

:+1: thanks for the explanation Matteo. The patch was already updated using the full path so no further changes are required.

dmonllao avatar Dec 11 '18 09:12 dmonllao

Any chance that we could merge this? The patch does not seem problematic.

dmonllao avatar Jan 30 '19 14:01 dmonllao

The failures reported by travis are unrelated to this patch.

dmonllao avatar Feb 15 '19 06:02 dmonllao