moodle-cs
moodle-cs copied to clipboard
moodlehq
Moodle Coding Style
I've also reviewed other dependencies and only PHPCompatibility is slightly "old" (May 2024), so decided not to bump it.
I know it may be a long shot, but I thought I'd give it a try since the necessary change is minimal and the potential payoff (at least for me)...
We ran into a few issues when parent:: wasn't being called for an overridden function, so I was inspired by #106. I thought maybe this would go into #92, but...
- Group by global type with comment. - Add comment to removed globals. - Add missing FULLSCRIPT literal. - Add missing XMLDB object. Fixes #181 I didn't remove any that...
In short, the $FULLSCRIPT global is missing from the list of allowed variable names. As of August 22, 2024, here are the allowed globals: https://github.com/moodlehq/moodle-cs/blob/89ff0acd727f8611cbafe5aea524614090b24ad9/moodle/Sniffs/NamingConventions/ValidVariableNameSniff.php#L32-L37 While I see the PHP...