moodle-cs

moodle-cs copied to clipboard

CodeChecker should be able to check for the rule about no string concatenation in lang files

1

MDLSITE-2719 agreed that string concatenation should not be allowed in lang files. It should be possible to get phpcs to check this for us, and it is a mistake people...

timhunt

TestCaseProviderSniff does not detect data provider method "class::provider"

1

You can share data providers between separate unit tests with: ```php /** * Test something. * * @dataProvider \some\class\test_class::test_provider */ public function test_something(){} ``` This generates the error message: `Data...

ziegenberg

Add new sniff to detect and remove constructor @return docs

4

andrewnicols

And also to current dev phpcompatibility 96072c30

stronk7

Introduced in #112 as a temporary solution until Moodle 4.2 is min required.

andrewnicols

Detect that setUpBeforeClass, setUp, tearDown, and tearDownAfterClass are always calling to parent

2

While it's not critical right now, we'll need to ensure that all the chain of parents are always executed, else, we may be missing cleaning stuff. More important, with PHPUnit...

stronk7

Update BoilerplateCommentSniff and add fixes.

5

There are a few troublesome things I find about BoilerplateCommentSniff: 1. It doesn't allow you to use `declare(strict_types=1)` in the standard place - on the same line as the opening...

micaherne

WIP: Missing docblocks for #[\Override]

2

Fixes #155 POC

andrewnicols

Analyse if we should start checking (4.4 and up) for setAccessible() reflection uses

2

The `setAccessible()` methods are, since PHP 8.1 no-op. That implies that, since Moodle 4.4.0 (that requires PHP 8.1), there shouldn't be any use in core. This issue is about to...

stronk7

Make MissingDoclock code more specific (Fixes #154)

1

andrewnicols