devdocs icon indicating copy to clipboard operation
devdocs copied to clipboard

[docs] Error in quizaccess#rulephp

Open mkpelletier opened this issue 3 months ago • 5 comments

What is the URL of the page?

https://moodledev.io/docs/5.0/apis/plugintypes/quizaccess#rulephp

What is the issue with this page?

The url in this line goes to a non-existent page: "Please refer to the inline phpdocs of the mod_quiz::rule_overridable interface for detailed descriptions of the functions and meaning."

Moreover, the class "rule_overridable" does not appear to be implemented as given in the following example.

Are you able to provide a patch for this?

No (Default)

mkpelletier avatar Sep 18 '25 13:09 mkpelletier

Ah! this is cause by the change that moved code to the /public folder.

timhunt avatar Sep 18 '25 15:09 timhunt

Needs changes in a few files, so I can't do it now using the github UI.

https://github.com/moodle/devdocs/pull/1435 is part of the required chagnes, but more work needed.

timhunt avatar Sep 18 '25 15:09 timhunt

I probalby won't have time. Helpful if someone else can finish fixing this.

timhunt avatar Sep 18 '25 15:09 timhunt

Thanks, Tim.

In addition to the path change, the target file doesn't exist either. For example, the earlier links work if you change the path: https://github.com/moodle/moodle/blob/main/public/mod/quiz/classes/local/access_rule_base.php < This exists

But at the bottom of the documentation, mutatis-mutundis: https://github.com/moodle/moodle/blob/main/public/mod/quiz/classes/local/rule_overridable.php < this does NOT exist

The net effect is that if I try to implement rule_overridable as described, it doesn't exist anywhere in core. How do I override an access rule if this is the case?

mkpelletier avatar Sep 19 '25 12:09 mkpelletier

This is now being dealt with in pull 1441.

timhunt avatar Oct 01 '25 16:10 timhunt