msal-flutter icon indicating copy to clipboard operation
msal-flutter copied to clipboard

Missing return statements after calls to result in SwiftMsalFlutterPlugin.swift

Open lyleresnick opened this issue 4 years ago • 0 comments

for example

at line 82, change:

      catch{
        result(FlutterError(code: "NO_ACCOUNT",  message: "Error retrieving an existing account", details: nil))
      }

to

      catch{
        result(FlutterError(code: "NO_ACCOUNT",  message: "Error retrieving an existing account", details: nil))
        return
      }

this code is only run when the keychain is not setup correctly and results in a crash

there are many other calls to result without returns following them

lyleresnick avatar Sep 30 '20 15:09 lyleresnick