GrooveScribe icon indicating copy to clipboard operation
GrooveScribe copied to clipboard

Please add low tom

Open MDJLengers opened this issue 4 years ago • 10 comments

I know I can add a low tom by changing the code but it won't play a sound. please add the low tom as default option.

MDJLengers avatar Jun 05 '20 18:06 MDJLengers

Good idea! I have the support in the code, but I don't have an audio sample for a low 16 inch tom. All the samples are recorded from Mike Johnston's drum set, so I will need him to set up a low tom and record it with similiar ambiance to the other toms.

montulli avatar Jun 06 '20 07:06 montulli

Hello, I 'm not a coder and I would also apreciate it, to have a second tom. Look here, I make the 16 tom al little higher with my "Music speed changer" in Android. Is the quality goog enough? 13 Tom.zip Sorry for my english. I' m only a little drummer from germany.

tomweiler avatar Oct 28 '21 14:10 tomweiler

Good idea! I have the support in the code, but I don't have an audio sample for a low 16 inch tom. All the samples are recorded from Mike Johnston's drum set, so I will need him to set up a low tom and record it with similiar ambiance to the other toms.

I'd be happy to donate a oneshot pack from drumdrops; the drumdrops packs are copyright-free according to their FAQ. 2Box also has an extensive set of samples on their site, I believe they are free to use (see the text at the top of that page), and I have kitbanks that bring together combinations of these samples together as cohesive sets.

retorquere avatar Mar 20 '22 21:03 retorquere

Hey @montulli , isn't this the same as low tom?

https://github.com/montulli/GrooveScribe/blob/master/soundfont/NewDrumSamples/MP3/Floor%20Tom.mp3

leocaseiro avatar Oct 06 '22 10:10 leocaseiro

Hi,

I found a fork of groovescribe with 3 toms: https://github.com/BenT-o/GrooveScribe

Many thanks to Ben Taylor: https://github.com/BenT-o !!!!!!

I found the fork with google and the help of this page: https://drummersbrainchild.com/

tomweiler avatar Oct 06 '22 12:10 tomweiler

@montulli any word on this or should we all move on?

jamesiri avatar Sep 12 '23 06:09 jamesiri

Can use here https://leocaseiro.github.io/GrooveScribe/

leocaseiro avatar Sep 12 '23 10:09 leocaseiro

I think adding a 3rd tom makes the UI too cluttered for the general use case. We need to find a way to turn it on and off for advanced users.

montulli avatar Sep 12 '23 16:09 montulli

@montulli Would more spacing (padding) between lines work?

I don't know why would be too cluttered, there're a lot of drum machines that have way more lines and elements than GrooveScribe.

Another reference is the https://daily-drum.com/drum-notation-editor/editor

Some other drum machines are: https://www.musicca.com/drum-machine and https://drumbit.app/

leocaseiro avatar Sep 12 '23 23:09 leocaseiro

Looks great @leocaseiro, thank you. Also thank for the original tool montulli!

Had my 2nd lesson this week and my teacher said nice tool, but there's a Tom missing. So glad I can use the fork. With the extra spacing it's pretty clear for writing things up, and for the actual reading/viewing there's a different view.

SirJohnDoe avatar Feb 07 '24 17:02 SirJohnDoe