stats icon indicating copy to clipboard operation
stats copied to clipboard

Published 20 hours ago • verified publisher icon montanaflynn

Distribution

Open neuegram opened this issue 8 years ago • 5 comments

I'll need to add docs, tests, and examples later...

neuegram avatar Mar 06 '16 23:03 neuegram

Thanks a lot @neuegram this looks great. Once there are some tests I can add the docs / examples.

montanaflynn avatar Apr 16 '16 23:04 montanaflynn

@neuegram @montanaflynn I wanted to introduce very similar changes. Is it Ok If I do a bit of reformatting around this code and push with the test-cases? Shivendra

MishraShivendra avatar Nov 02 '17 17:11 MishraShivendra

@MishraShivendra that's fine with me

montanaflynn avatar Nov 02 '17 18:11 montanaflynn

Not sure how should I do this. Should I fork @neuegram's repo and give pull request to him, updating this pull request? or Merge this pull request to a private branch where I can place my changes and then eventually merge that to mainline?

Shivendra

MishraShivendra avatar Nov 09 '17 17:11 MishraShivendra

I would merge it into your own branch and submit a PR from that.

montanaflynn avatar Nov 09 '17 18:11 montanaflynn