monosi icon indicating copy to clipboard operation
monosi copied to clipboard

Remove EUI Dependency

Open iporollo opened this issue 2 years ago • 4 comments

Description

We were originally using the EUI user interface library to build some of our components. We have since switched to the React Bootstrap library, but have not fully removed the EUI dependency (since we are still using some of their components for forms). The EUI dependency has unnecessary second order dependencies such as moment.js that we don't use but make the build heavier

Expected behavior

We need to refactor the forms that use EUI components into Bootstrap forms to fully remove the EUI dependency. Then, we need to delete EUI from the package.json.

Steps to reproduce

  1. Go to Sources or Integrations page
  2. Click on Create Data Source or Create Integration
  3. Notice that the drawer is an EUI component

Additional context

image image

iporollo avatar Apr 13 '22 17:04 iporollo

@iporollo Hi, I am a beginner. should the drawer look the same after it is replaced with react-bootstrap components?

yokaiemporer avatar Apr 13 '22 17:04 yokaiemporer

Hi @yokaiemporer! Appreciate you helping out here. Yes, ideally the drawer looks similar to the original one, with the color scheme being the boostrap primary color (purple) rather than the EUI blue.

iporollo avatar Apr 13 '22 18:04 iporollo

Here's a link to the react-bootstrap components we're looking to replace it with: https://react-bootstrap.github.io/forms/overview/

And here's an example in the code where we already use those components for a form: https://github.com/monosidev/monosi/blob/master/src/ui/src/pages/app/onboarding/GettingStarted/index.tsx

unkrich avatar Apr 13 '22 18:04 unkrich

Thank you , will try replacing and confirm

yokaiemporer avatar Apr 13 '22 18:04 yokaiemporer