LicensePlist icon indicating copy to clipboard operation
LicensePlist copied to clipboard

Add a linting functionality

Open stherold opened this issue 1 year ago • 6 comments

Since you already did a great job finding all licenses (Kudos), it would be easy to also verify that the dependencies all have licenses that wre whitelisted somewhere. Somewhere could be in the config file or a separate file.

I got the idea from here which uses decision files similar to the one blelow to lint licenses. But that tool doesn't seem to work properly with iOS dependency managers.

Example Decision File

---
- - :permit
  - MIT
  - :who: blackjacx
    :why:
    :versions: []
    :when: 2023-07-27 07:50:57.411184000 Z
- - :permit
  - ruby
  - :who: blackjacx
    :why:
    :versions: []
    :when: 2023-07-27 07:51:08.681913000 Z
- - :permit
  - Apache 2.0
  - :who: blackjacx
    :why:
    :versions: []
    :when: 2023-07-27 07:51:14.222256000 Z
- - :permit
  - BSD
  - :who: blackjacx
    :why:
    :versions: []
    :when: 2023-08-02 20:10:55.731775981 Z
- - :permit
  - New BSD
  - :who: blackjacx
    :why:
    :versions: []
    :when: 2023-08-02 20:10:55.731775981 Z
- - :permit
  - Simplified BSD
  - :who: blackjacx
    :why:
    :versions: []
    :when: 2023-08-02 20:11:03.882864297 Z

stherold avatar Oct 06 '23 14:10 stherold

Do you think this is an addition that could make it into LicensePlist?

stherold avatar Oct 20 '23 12:10 stherold

@stherold

Thank you for your suggestion. However, I feel it is out of the scope of the functionality this tool should provide 🤔

mono0926 avatar Nov 10 '23 06:11 mono0926

Okay thanks for the information. We will then use one of the export options to get the detected licenses by LicensePlist and write a script to do that task on our side.

One question though, what do you think about a JSON export option since that is easier to parse as the tooling is more popular than with CSV.

stherold avatar Nov 28 '23 15:11 stherold

@stherold

One question though, what do you think about a JSON export option since that is easier to parse as the tooling is more popular than with CSV.

I think it is nice to have feature 👍

mono0926 avatar Nov 29 '23 05:11 mono0926

Should we keep it in this ticket or open a new one?

stherold avatar Nov 29 '23 14:11 stherold

@stherold

I've closed this issue. You can create a pull request directly without an issue for CSV option support 🙏

mono0926 avatar Nov 30 '23 04:11 mono0926