LicensePlist icon indicating copy to clipboard operation
LicensePlist copied to clipboard

Duplicates in latest_result.txt file

Open schjonhaug opened this issue 4 years ago • 3 comments

When specifying a dependency from GitHub in license_plist.yml like so:

github:
  - owner: youtube
    name: youtube-ios-player-helper
    version: 1.0.2
manual:
  - name: KeychainItemWrapper
    file: "Challenge/Frameworks/KeychainItemWrapper/LICENSE"
  - name: "Reachability"
    file: "Challenge/Frameworks/Reachability/LICENSE"
  - name: "SwiftGif"
    file: "Challenge/Frameworks/SwiftGif/LICENSE"
  - name: "Firebase"
    file: "Challenge/Frameworks/Firebase/LICENSE"

I get duplicates in the latest_results.txt file:

name: youtube-ios-player-helper, nameSpecified: , owner: youtube, version: 1.0.2

name: youtube-ios-player-helper, nameSpecified: , owner: youtube, version: 1.0.2

name: youtube-ios-player-helper, nameSpecified: , owner: youtube, version: 1.0.2

name: Amplitude-iOS, nameSpecified: Amplitude, owner: amplitude, version: 5.2.0

name: lottie-ios, nameSpecified: Lottie, owner: airbnb, version: 3.1.8

name: swift-sdk, nameSpecified: IterableSDK, owner: Iterable, version: 6.2.8

name: Firebase, nameSpecified: , version: 
body: 
                   …

name: KeychainItemWrapper, nameSpecified: , version: 
body: The MIT License (MIT…

name: Reachability, nameSpecified: , version: 
body: # Reachability

Copy…

name: SwiftGif, nameSpecified: , version: 
body: The MIT License (MIT…

add-version-numbers: true

LicensePlist Version: 2.16.0

schjonhaug avatar Jul 09 '20 12:07 schjonhaug

Console output:

➜  kahoot-native-ios git:(andreas/update-youtube-code) ✗ ./scripts/generate-acknowledgements.sh
[2020-07-09T14:10:35.573+02:00] [INFO] Start
[2020-07-09T14:10:35.578+02:00] [WARNING] not found: Pods/Target%20Support%20Files -- file:///Users/schjonhaug/Development/Kahoot/kahoot-native-ios/
[2020-07-09T14:10:35.578+02:00] [WARNING] not found: Pods/_Prebuild/Target%20Support%20Files -- file:///Users/schjonhaug/Development/Kahoot/kahoot-native-ios/
[2020-07-09T14:10:35.578+02:00] [INFO] Pods License parse start
[2020-07-09T14:10:35.578+02:00] [WARNING] Not found: Pods/Manifest.lock -- file:///Users/schjonhaug/Development/Kahoot/kahoot-native-ios/.
[2020-07-09T14:10:35.578+02:00] [WARNING] Not found: Cartfile.resolved -- file:///Users/schjonhaug/Development/Kahoot/kahoot-native-ios/.
[2020-07-09T14:10:35.578+02:00] [WARNING] Not found: Cartfile -- file:///Users/schjonhaug/Development/Kahoot/kahoot-native-ios/.
[2020-07-09T14:10:35.578+02:00] [INFO] Carthage License collect start
[2020-07-09T14:10:35.578+02:00] [WARNING] youtube-ios-player-helper was loaded from config YAML.
[2020-07-09T14:10:35.578+02:00] [WARNING] Not found: Mintfile -- file:///Users/schjonhaug/Development/Kahoot/kahoot-native-ios/.
[2020-07-09T14:10:35.578+02:00] [INFO] Mint License collect start
[2020-07-09T14:10:35.578+02:00] [WARNING] youtube-ios-player-helper was loaded from config YAML.
[2020-07-09T14:10:35.578+02:00] [WARNING] Not found: Package.resolved -- file:///Users/schjonhaug/Development/Kahoot/kahoot-native-ios/.
[2020-07-09T14:10:35.578+02:00] [WARNING] Not found: Package.swift -- file:///Users/schjonhaug/Development/Kahoot/kahoot-native-ios/.
[2020-07-09T14:10:35.579+02:00] [INFO] Swift Package Manager License collect start
[2020-07-09T14:10:35.580+02:00] [WARNING] youtube-ios-player-helper was loaded from config YAML.
[2020-07-09T14:10:35.580+02:00] [INFO] Manual License start
[2020-07-09T14:10:35.581+02:00] [INFO] license download start(owner: youtube, name: youtube-ios-player-helper)
[2020-07-09T14:10:35.581+02:00] [INFO] license download start(owner: youtube, name: youtube-ios-player-helper)
[2020-07-09T14:10:35.581+02:00] [INFO] license download start(owner: youtube, name: youtube-ios-player-helper)
[2020-07-09T14:10:35.581+02:00] [INFO] license download start(owner: amplitude, name: Amplitude-iOS)
[2020-07-09T14:10:35.581+02:00] [INFO] license download start(owner: airbnb, name: lottie-ios)
[2020-07-09T14:10:35.581+02:00] [INFO] license download start(owner: Iterable, name: swift-sdk)
[2020-07-09T14:10:36.122+02:00] [INFO] Deleted exiting plist within Acknowledgements
[2020-07-09T14:10:36.122+02:00] [INFO] Directory created: Challenge/Challenge/Settings.bundle/ -- file:///Users/schjonhaug/Development/Kahoot/kahoot-native-ios/
[2020-07-09T14:10:36.126+02:00] [INFO] End
[2020-07-09T14:10:36.126+02:00] [INFO] ----------Result-----------
[2020-07-09T14:10:36.126+02:00] [INFO] # Missing license:
[2020-07-09T14:10:36.126+02:00] [INFO] None 🎉
[andreas/update-youtube-code e91dbb22] Regenerated acknowledgements file
 4 files changed, 14 insertions(+), 16 deletions(-)

schjonhaug avatar Jul 09 '20 12:07 schjonhaug

Thanks for the report.

Are you having trouble with this? I regard latest_result.txt as merely last result snapshot, which is used only for detecting license source diff. It can be a hash value instead of human readable text.

mono0926 avatar Jul 10 '20 01:07 mono0926

No, everything is working as expected. Just wanted to report it.

schjonhaug avatar Jul 10 '20 06:07 schjonhaug