monodevelop icon indicating copy to clipboard operation
monodevelop copied to clipboard
verified publisher icon mono

Fixes compatbaseline check for HttpHeaderKind change

Open josegallardo opened this issue 5 years ago • 4 comments

This is required for insertion PR https://github.com/xamarin/md-addins/pull/6190

josegallardo avatar Jan 15 '20 18:01 josegallardo

Not sure this is correct. PRs are currently failing since they are building on Mac 10.13 but the master branch is building with Catalina where the compat check is working (was updated by @dalexsoto and this change here seems to revert this change made by Alex - https://github.com/mono/monodevelop/pull/9525/files)

mrward avatar Jan 15 '20 20:01 mrward

Not sure this is correct. PRs are currently failing since they are building on Mac 10.13 but the master branch is building with Catalina where the compat check is working (was updated by @dalexsoto and this change here seems to revert this change made by Alex - https://github.com/mono/monodevelop/pull/9525/files)

Then we shouldn't merge this change and just merge the md-addins PRs even with CompatBaseCheck failing?

Looks like that's the case, and we should just close this PR and merge https://github.com/xamarin/md-addins/pull/6190

Thanks @mrward for the quick catch! @dalexsoto can you please confirm?

josegallardo avatar Jan 15 '20 21:01 josegallardo

Adding the do-not-merge label for now until we can confirm this should be closed.

josegallardo avatar Jan 15 '20 21:01 josegallardo

Then we shouldn't merge this change and just merge the md-addins PRs even with CompatBaseCheck failing? Correct. @josegallardo Yeah I would just merge the md-addins change.

mrward avatar Jan 16 '20 09:01 mrward