monodevelop
monodevelop copied to clipboard
mono
[Version Control] Fixes error adding new files to the Solution Items under Version Control
We have some changes here. The first one was adding the file in the solution. If there is no "Solution Items" folder, we create it. On the other hand, trying to add the file to the repository (Add command) a validation was made taking into account the ActiveDocument that we will only have if the document is open (it is not always the case, or can even deal with a file that is not text). Validation changed.
Fixes VSTS #715157
The approach of the fix is not quite right. The problem is in the solution pad, where for some reason commands are not enabled. Solution pad commands are not handled by FileVersionControlCommandHandler. This class handles commands that apply to the active document, but not for the solution pad. Solution pad commands are handled by a tree node command handler, together with a corresponding NodeBuilderExtension. Maybe for some reason the node builder extension is not being applied to solution items, so handlers are not enabled.
@Lluis, you are right. The problem seems to be the node type validation from VersionControlNodeExtension in the method CanBuildNode (SolutionFolderItem). Will send changes soon!
