monodevelop icon indicating copy to clipboard operation
monodevelop copied to clipboard

Published 20 hours ago • verified publisher icon mono

[Mac] Use NSAppleScript instead of Carbon to spawn the terminal process

Open iainx opened this issue 6 years ago • 8 comments

Uses Cocoa's NSAppleScript class to do all the heavy lifting of compiling and executing the AppleScript code.

Fixes VSTS #703355.

iainx avatar Oct 05 '18 14:10 iainx

This will break md-addins: https://github.com/xamarin/md-addins/blob/c1936f152d35efb4c83a0cfd798d5f1ea0c19157/MonoDevelop.MacDev/MonoDevelop.MacDev/XcodeSyncing/XcodeMonitor.cs#L429

mhutch avatar Oct 05 '18 15:10 mhutch

@mhutch Ah, of course.

iainx avatar Oct 05 '18 20:10 iainx

@iainx Can you explain what does this fix? Can we have a work item for it?

slluis avatar Oct 10 '18 21:10 slluis

It doesn't fix anything really, it just removes some old complicated Carbon code.

iainx avatar Oct 11 '18 08:10 iainx

Ok, I'm not qualified to review this, somebody else will have to.

slluis avatar Oct 11 '18 09:10 slluis

I've made a user story for removing carbon code, and added this as a task under it https://devdiv.visualstudio.com/DevDiv/_workitems/edit/703355

iainx avatar Oct 11 '18 09:10 iainx

https://devdiv.visualstudio.com/DevDiv/_workitems/edit/703346 is the parent user story

iainx avatar Oct 11 '18 09:10 iainx

We can break API in release-8.0. We should rebase it on top of that.

Therzok avatar Nov 22 '18 21:11 Therzok