[Addin] To allow CBinding to use "Project" property

[gitexperience]

CMakeProject being derived from SolutionItem is unable to access the "Project" property. The PR is intended to test the changes needed to make the "Project" property available to the CBinding's CMakeProject.

[monojenkins]

Hello! I'm the build bot for the Mono project.

I need approval from a Mono team member to build this pull request. A team member should reply with "approve" to approve a build of this pull request, "whitelist" to whitelist this and all future pull requests from this contributor, or "build" to explicitly request a build, even if one has already been done. Additional trigger words are available here.

Contributors can ignore this message.

[slluis]

It looks good overall!

[mhutch]

build

[mhutch]

@slluis - do you think it would make sense to use WorkspaceObject instead of SolutionItem for the type of Owner?

[slluis]

@mhutch I think SolutionItem is ok.

[mhutch]

@slluis I was just wondering about things like items in solution folders. It would be painful to have to change the type of "Owner" later.

[slluis]

@mhutch there isn't much functionality we can use at this abstraction level, it could as well be an Object. In any case solution folder items is a real use case, so I'm ok with using WorkspaceObject.

[mhutch]

@gitexperience could you change SolutionItem to WorkspaceObject per above comment?

There may be some things that will not work because they access members that are not present on WorkspaceObject, but those can conditionally cast to the derived types that do have this functionality.

var policies = Owner?.Policies;

could become

var policies = (Owner as IPolicyProvider)?.Policies;

and

if (window.ViewContent.Owner != null)
    window.ViewContent.Owner.Modified += HandleProjectModified;

could become

if (window.ViewContent.Owner is SolutionFolderItem solutionItem)
    solutionItem.Modified += HandleProjectModified;
else if (window.ViewContent.Owner is WorkspaceItem workspaceItem)
    workspaceItem.Modified += HandleWorkspaceItemModified;

[mhutch]

@gitexperience also, please rebase onto master

[mhutch]

Can you please rebase this onto master? The changes tab shows a lot of changes from master that appear to have been somehow cherry-picked.

[gitexperience]

@mhutch, rebasing done! Can you please review the changes ?

[gitexperience]

@mhutch , Done!

[mhutch]

Looks good! @slluis?

[gitexperience]

@slluis @mhutch do we need more changes in this PR ? I just rebased it again because of some merge conflicts.

[mhutch]

It looks good to me but I'd like @slluis to take a look too

[gitexperience]

@slluis do we need more changes in this PR ?