gtk-sharp icon indicating copy to clipboard operation
gtk-sharp copied to clipboard

Published 20 hours ago • verified publisher icon mono

Update GTK+ to version 3.14.15

Open nacho opened this issue 8 years ago • 6 comments

Based on the patches from Mikkel Kruse Johnsen.

See that the CSS demo is currently disabled since the CssProvider is not properly picked up for some reason. We will need to research a bit on this but for now it is good enough doing it without.

nacho avatar May 20 '16 15:05 nacho

Hello! I'm the build bot for the Mono project.

I need approval from a Mono team member to build this pull request. A team member should reply with "approve" to approve a build of this pull request, "whitelist" to whitelist this and all future pull requests from this contributor, or "build" to explicitly request a build, even if one has already been done.

Contributors can ignore this message.

monojenkins avatar May 20 '16 15:05 monojenkins

Hello! I'm the build bot for the Mono project.

I need approval from a Mono team member to build this pull request. A team member should reply with "approve" to approve a build of this pull request, "whitelist" to whitelist this and all future pull requests from this contributor, or "build" to explicitly request a build, even if one has already been done.

Contributors can ignore this message.

monojenkins avatar May 20 '16 15:05 monojenkins

If this code is based on another PR, please put the link to it, and explain the adjustments you made over his work. Thanks

knocte avatar May 21 '16 09:05 knocte

Here we go. Please let me know if you need me to provide more info.

nacho avatar May 21 '16 10:05 nacho

Based on the patches from Mikkel Kruse Johnsen. See the fork: https://github.com/openmedicus/gtk-sharp/

Prefer that you include the link to his earlier PR, to see previous conversations about this upgrade.

There are also 3 new patches that need to be applied due to the scanner hanging or giving an error when parsing the source code. Two of those patches are already in GTK upstream see:

Thanks for providing info about this! And URLs of upstream patches. But I only see 2 URLs, not 3.

See that there are also some generator problems with GtkWidgetClass.

Meh, his commit doesn't delve into what those generator problems are. It could be great if you could give more insight about this before we merge this workaround.

knocte avatar May 21 '16 10:05 knocte

There we go. Adding also @mikkeljohnsen in case he can give some insight about the GtkWidgetClass issue.

nacho avatar May 21 '16 13:05 nacho