Fix Xamarin.Android SDK locations to match the latest paths.

[atsushieno]

trafficstars

Now we have:

bin/
include/
lib/xamarin.android/lib/xbuild
lib/xamarin.android/lib/xbuild/Xamarin/Android (`mandroid` in the past)
lib/xamarin.android/lib/xbuild-frameworks/MonoAndroid/v*
Version*

[atsushieno]

One more thing: removed debug runtime check to not exclude xamarin-android OSS SDK especially on Linux.

[tritao]

This seems to break the build on Windows, can we keep backwards compatibility here?

[jonathanpeppers]

So the reason this is not working on Windows, is the structure of the OSS zip at: https://jenkins.mono-project.com/view/Xamarin.Android/job/xamarin-android/682/Azure/processDownloadRequest/xamarin-android/oss-xamarin.android_v8.0.0.37_Darwin-x86_64_HEAD_376f684.zip

./bin
./include
./lib
./lib/xbuild
./lib/xbuild/Novell
./lib/xbuild/Xamarin
./lib/xbuild/Xamarin/Android
./lib/xbuild/Xamarin/Android/lib
./lib/xbuild-frameworks
./lib/xbuild-frameworks/MonoAndroid
./lib/xbuild-frameworks/MonoAndroid/v1.0
./lib/xbuild-frameworks/MonoAndroid/v1.0/Facades
./lib/xbuild-frameworks/MonoAndroid/v2.3
./lib/xbuild-frameworks/MonoAndroid/v7.0

Since this is what Embeddinator is bundling, it should work with Embeddinator on NuGet or if you run the Download-Xamarin-Android cake task. There are a decent amount of changes to be done to support both the OSS zip and the system Xamarin.Android. I believe there is some path lookup logic we are using in Xamarin.Android.Build.Tests that could be used (I recently made it work on Windows).

I'm not sure how the macOS CI passed here... Does it run Generate-Android?

[tritao]

Looks like the Travis Cake steps were missing the Android tests, I've sent a PR to add it.

[atsushieno]

Thanks for the insights. Let me get a working e4k environment first, I need it for my local presentation :( Working on patches to come next.

[jonathanpeppers]

@atsushieno I think you got things working on Linux without this PR?

I think reworking things to use the system Xamarin.Android should replace these change. Hopefully I can work on that soonish?

[atsushieno]

Not at all. Things are broken.

[atsushieno]

Why did you close it?

[jonathanpeppers]

We are trying to cleanup old issues/prs. We can reopen if this PR is still valid and we can get the CI to pass.

[atsushieno]

You didn't actually work on it. Anyone who had the same problem will see my PR and can improve it based on the existing work. You are just hiding your problem.

[jonathanpeppers]

We are just closing anything that didn't have activity for a few months, not hiding anything.

Sorry if I wasn't clear,

[atsushieno]

In case it's not clear, I had created so many PRsissues that fix various issues and that have been kept untouched. I know there is no one for a while so I just left them, but that also means no one can expect any further bugfix contributions from me.