CppSharp icon indicating copy to clipboard operation
CppSharp copied to clipboard
verified publisher icon mono

std::wstring support for C#

Open strentler opened this issue 4 years ago • 4 comments

  • In IgnoreSystemDeclarationsPass: Explicitly renamed basic_string:: assign and data methods becasue otherwise some following implicit renamings make the code not working (this issue can be observer when a std::string and std::wstring is present in the C++ input classes)
  • Removed the resetting of method names in SpecializationMethodsWithDependentPointersPass becasue this reverts changes which are made in the pass IgnoreSystemDeclarationsPass
  • added wstring type map
  • added a hacky flag to be able to run tests when the option MarshalCharAsManagedChar is set to false

strentler avatar Aug 30 '21 15:08 strentler

CLA assistant check
All CLA requirements met.

dnfadmin avatar Aug 30 '21 15:08 dnfadmin

Our CI fails with this PR. Could you please get at least the OS you use working?

ddobrev avatar Aug 30 '21 16:08 ddobrev

Got it now partly threw your CI. MacOS is missing.

To make this PR clean, there is still some work to do.

strentler avatar Sep 14 '21 12:09 strentler

@strentler thank you very much for this piece, it's extremely important. Forget about macOS, I can take care of that part. I hope I'll be done by the time you've sent your cleansing.

ddobrev avatar Sep 18 '21 20:09 ddobrev