monkeytype icon indicating copy to clipboard operation
monkeytype copied to clipboard

impr: added my username to contributor list

Open Emma1-png opened this issue 3 weeks ago • 2 comments

Description

Checks

  • [ ] Adding/modifying Typescript code?
    • [ ] I have used qs, qsa or qsr instead of JQuery selectors.
  • [ ] Adding quotes?
    • [ ] Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • [ ] Adding a language?
    • Make sure to follow the languages documentation
    • [ ] Add language to packages/schemas/src/languages.ts
    • [ ] Add language to exactly one group in frontend/src/ts/constants/languages.ts
    • [ ] Add language json file to frontend/static/languages
  • [ ] Adding a theme?
    • Make sure to follow the themes documentation
    • [ ] Add theme to packages/schemas/src/themes.ts
    • [ ] Add theme to frontend/src/ts/constants/themes.ts
    • [ ] Add theme css file to frontend/static/themes
    • [ ] Add some screenshots of the theme, especially with different test settings (colorful, flip colors) to your pull request
  • [ ] Adding a layout?
    • [ ] Make sure to follow the layouts documentation
    • [ ] Add layout to packages/schemas/src/layouts.ts
    • [ ] Add layout json file to frontend/static/layouts
  • [ ] Adding a font?
    • Make sure to follow the themes documentation
    • [ ] Add font file to frontend/static/webfonts
    • [ ] Add font to packages/schemas/src/fonts.ts
    • [ ] Add font to frontend/src/ts/constants/fonts.ts
  • [ ] Check if any open issues are related to this PR; if so, be sure to tag them below.
  • [ ] Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • [ ] Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.

Closes #

Emma1-png avatar Dec 17 '25 11:12 Emma1-png

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and also include the author name at the end inside parenthesis. It looks like your proposed title needs to be adjusted.

Details:

Title "impr: added my username to contributor list"
didn't match the configured pattern. Please ensure that the title
contains your name so that you can be credited in our changelog.

A correct version would look something like:

feat: add new feature (@github_username) impr(quotes): add english quotes (@username) fix(leaderboard): show user rank correctly (@user1, @user2, @user3)

github-actions[bot] avatar Dec 17 '25 11:12 github-actions[bot]

The list is generated from the list of contributors from GitHub. Don't open PRs adding your name to the list.

Leonabcd123 avatar Dec 17 '25 11:12 Leonabcd123

I have something in the works on a private fork. It is big. I am putting this here so that I don't forget to later.

Emma1-png avatar Dec 17 '25 13:12 Emma1-png

You don't need to add your name. Next time the list will be updated, your name will appear (if your PR is accepted). Please close this.

Leonabcd123 avatar Dec 17 '25 13:12 Leonabcd123

Okay, I will keep at it, and sync from whence it is done. I may need your help though. I am adding another sound to the 'play sound on click' category. I have the sound in the "click16" folder in my repository (it's on my github profile), but I am having issues. How do I get it so that it is able to have the button that users can click on in the settings? Thanks if you can help

Emma1-png avatar Dec 17 '25 13:12 Emma1-png