monkeytype icon indicating copy to clipboard operation
monkeytype copied to clipboard

"No internet connection" banner not disappearing even after re-connecting

Open SeerLite opened this issue 9 months ago • 2 comments

Did you clear cache before opening an issue?

  • [x] I have cleared my cache

Is there an existing issue for this?

  • [x] I have searched the existing issues

Does the issue happen when logged in?

Yes

Does the issue happen when logged out?

Yes

Does the issue happen in incognito mode when logged in?

Yes

Does the issue happen in incognito mode when logged out?

Yes

Account name

SeerLite

Account config

No response

Current Behavior

When disconnecting from the internet (by disconnecting from the current network or suspending the computer for example), a closable banner at the top of the page that says "No internet connection" appears.

After reconnecting to the internet, a notification saying "You're back online" appearing shows up but the "No internet connection banner" stays and doesn't go away until manually dismissed by clicking on the X.

Expected Behavior

The banner should disappear at the same time the "You're back online" notification is shown.

Steps To Reproduce

  1. Go to monkeytype.com with internet connection
  2. Disconnect from the internet.
  3. Wait for "No internet connection" banner to appear.
  4. Connect to the internet.
  5. Wait for the "You're back online" notification and see how the banner stays.

Environment

  • OS: NixOS (Linux)
  • Browser: Firefox
  • Browser Version: 136.0.1

Anything else?

This banner is very annoying as when I suspend my computer (which I do very often) the network connection is lost, and I have to dismiss the banner everytime I focus the tab after doing so.

SeerLite avatar Mar 21 '25 19:03 SeerLite

Can I work on this?

AmanWebDev2 avatar Mar 21 '25 19:03 AmanWebDev2

I have noticed one more issue related to this. After going offline, if I manually cancel the offline banner and then go online again, the toast message "You're back online" does not appear as expected.

Here is a video -

https://github.com/user-attachments/assets/5fe47859-6868-4f94-b7f4-866ee652f7d5

I have fixed this issue! 😁👍 Hope this PR gets merged soon!

Thanks

AmanWebDev2 avatar Mar 22 '25 20:03 AmanWebDev2

This should be fixed already, let me know if it comes back.

Miodec avatar Jul 09 '25 10:07 Miodec