monkeytype icon indicating copy to clipboard operation
monkeytype copied to clipboard

simon says doesn't show shifts

Open gtbot2007 opened this issue 1 year ago • 16 comments

Did you clear cache before opening an issue?

  • [x] I have cleared my cache

Is there an existing issue for this?

  • [X] I have searched the existing issues

Does the issue happen when logged in?

Yes

Does the issue happen when logged out?

Yes

Does the issue happen in incognito mode when logged in?

Yes

Does the issue happen in incognito mode when logged out?

Yes

Account name

gtbot2007

Account config

No response

Current Behavior

When using simon says, shifts never show on the keyboard

Expected Behavior

It should show shifts

Steps To Reproduce

  1. turn on simon says
  2. choose a code language
  3. when it asks to type < or > it shows as , and . which is the unshifted version

Environment

OS: Windows 10 Browser: Google Chrome

Anything else?

No response

gtbot2007 avatar Jan 03 '25 20:01 gtbot2007

related to the fixed bug #4273

gtbot2007 avatar Jan 03 '25 20:01 gtbot2007

~~Lack of shifts on the keyboard is a stylistic choice. Ill add a different style for highlighted keys that need to be shifted.~~

Nevermind, that wont work - i fully understand the issue now. Not sure what to do about this for now.

Miodec avatar Jan 07 '25 11:01 Miodec

@Miodec And if you disable punctuation at simon_says, what do you think?

ippatev avatar Jan 13 '25 21:01 ippatev

That doesn’t quite make sense if my language is set to a programming language

gtbot2007 avatar Jan 13 '25 22:01 gtbot2007

@gtbot2007, I suggested fixing this bug this way, because as described above, it doesn't match the stylistic choices

ippatev avatar Jan 14 '25 06:01 ippatev

I don’t see why we can’t just (as an example) change the label of the . key to > when that’s what I need to type?

gtbot2007 avatar Jan 14 '25 10:01 gtbot2007

I don’t see why we can’t just (as an example) change the label of the . key to > when that’s what I need to type?

Because it doesn't indicate in any way that you need to use shift.

Miodec avatar Jan 14 '25 11:01 Miodec

Just make it blue or something idk

gtbot2007 avatar Jan 14 '25 12:01 gtbot2007

Wont work in blue themes. Also doesn't explain to the user that 'blue is shift'

Miodec avatar Jan 14 '25 12:01 Miodec

I don’t see why it would need to. The character on the key would be what you should be typing. If that character requires shift you should probably know that lol

gtbot2007 avatar Jan 14 '25 12:01 gtbot2007

The issue seems to be from the keymap config that the next setting doesn't capitlize on dynamic AND next mode. Hopefully I'll sumbit a working PR in a few hours that fixes it.

Perseus333 avatar Mar 14 '25 18:03 Perseus333

The issue seems much more complicated since there's no bridge between the "next" keymapMode and the case of the character. I'm working on a solution, but I can't guarantee I'll succeed, so if anyone wants and can fix this, consider it as if it isn't worked on. l

Perseus333 avatar Mar 15 '25 22:03 Perseus333

I suggest displaying shift keys on the sides of the displayed keyboard and highlighting the "correct" shift key whenever shift needs to be used. For example, if I need to type capitalized E, highlight e and right shift. If I need to type capitalized P, highlight p and left shift. Could also add config settings for forcing a specific shift key

ericshu6 avatar May 03 '25 22:05 ericshu6

This will require a significant rewrite of the keymap element then. It will remain a to-do for now, as its not mission critical.

Miodec avatar May 12 '25 15:05 Miodec

the on-display-keyboard doesn't show "<" and " >" keys in regular typing testes as well, need to add that from there too....

justsachin-kumar avatar Jul 14 '25 07:07 justsachin-kumar

i took 60 sececond test with the html lang. and in login or logout it doesn't show shift key and other dual keys.

justsachin-kumar avatar Jul 14 '25 07:07 justsachin-kumar