monkeytype icon indicating copy to clipboard operation
monkeytype copied to clipboard

feat(lang): add Bengali language (@SubhodeepRoy2)

Open Subh0d33p opened this issue 1 year ago • 10 comments

Added Bengali as a language using the English alphabet (transliteration). Although Bengali was already included, it was in the Bengali script. This contribution adds Bengali words written in the English alphabet. [feat(languages): add bengali (http://github.com/SubhodeepRoy2) ]

Subh0d33p avatar Sep 28 '24 05:09 Subh0d33p

Does it make sense to put it in the same language group as already existing language? I think we have similar case for Serbian, where we use both cyrillic and latin versions.

rammba avatar Sep 28 '24 08:09 rammba

That can also be done. or it could be added as a separate language variant. Both works, what's your suggestion?

Subh0d33p avatar Sep 28 '24 08:09 Subh0d33p

I would say it's better to group them, since they are related. I see that also sanskrit language is in the same group as sanskrit_roman which is similar case as yours, right?

rammba avatar Sep 28 '24 09:09 rammba

Okay, I'll group them. @rammba can you help me with the errors that I'm getting here? image

Subh0d33p avatar Sep 28 '24 11:09 Subh0d33p

I think you should rename title of this PR to something like: feat(bengali): add Bengali language (@SubhodeepRoy2).

rammba avatar Sep 28 '24 12:09 rammba

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

github-actions[bot] avatar Oct 07 '24 10:10 github-actions[bot]

This PR is stale. Please trigger a re-run of the PR check action.

github-actions[bot] avatar Oct 14 '24 20:10 github-actions[bot]

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

github-actions[bot] avatar Oct 15 '24 12:10 github-actions[bot]

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

github-actions[bot] avatar Oct 15 '24 16:10 github-actions[bot]

This PR is stale. Please trigger a re-run of the PR check action.

github-actions[bot] avatar Oct 23 '24 20:10 github-actions[bot]