monkeytype icon indicating copy to clipboard operation
monkeytype copied to clipboard
verified publisher icon monkeytypegame

impr(themes): added and Created new theme (StickminBruv)

Open StickminBruv opened this issue 1 year ago • 1 comments

Description

I made a new theme idea called carmen red, based off a color someone made. It's my first time doing this stuff on github, so I know I messed up a lot. Screenshot 2024-04-26 192158

Checks

  • [ ] Adding quotes?
    • [ ] Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • [x] Adding a language or a theme?
    • [ ] If is a language, did you edit _list.json, _groups.json and add languages.json?
    • [x] If is a theme, did you add the theme.css?
      • Also please add a screenshot of the theme, it would be extra awesome if you do so!
  • [ ] Check if any open issues are related to this PR; if so, be sure to tag them below.
  • [x] Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • [x] Make sure to include your GitHub username inside parentheses at the end of the PR title

Closes #

StickminBruv avatar Apr 26 '24 23:04 StickminBruv

I believe that in order to follow the conventional commits standards, you must name your pull request "impr(themes): added and Created new theme"

cobie8708 avatar Apr 27 '24 00:04 cobie8708

Text color must be close to white/black (can be slightly tinted). Error color must be clearly visible (right now its very hard to spot). Missing colors in the _list file (take a look at other themes)

Miodec avatar May 02 '24 12:05 Miodec

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/8938281407

monkeytypegeorge avatar May 03 '24 11:05 monkeytypegeorge

Text color must be close to white/black (can be slightly tinted). Error color must be clearly visible (right now its very hard to spot). Missing colors in the _list file (take a look at other themes)

I have now changed the text color, the error color, and the _list file I believe the error color is still wrong, so correct me if I am really wrong with the error color

StickminBruv avatar May 03 '24 11:05 StickminBruv

Please post some updated screenshots

Miodec avatar May 06 '24 12:05 Miodec

Please post some updated screenshots

Updated screenshot for,comment

StickminBruv avatar May 06 '24 22:05 StickminBruv

Errors are still not visible.

Miodec avatar May 07 '24 08:05 Miodec

Changed again Im definitely stuck in an endless loop, but that's alright

StickminBruv avatar May 07 '24 19:05 StickminBruv

You cant really use red errors in a red theme..

Miodec avatar May 08 '24 12:05 Miodec

Sorry, looks like i broke your pr. If you work on the theme again please make a new PR. Again, sorry.

Miodec avatar May 08 '24 17:05 Miodec

Sorry, looks like i broke your pr. If you work on the theme again please make a new PR. Again, sorry.

It's alright, I can just very easily copy and paste stuff Also the comment about red errors in a red theme kinda makes sense now..

StickminBruv avatar May 08 '24 23:05 StickminBruv