monkeytype icon indicating copy to clipboard operation
monkeytype copied to clipboard

Published 20 hours ago • verified publisher icon monkeytypegame

impr(SEO): Semantic HTML (plbstl)

Open plbstl opened this issue 5 months ago • 3 comments

Description

I made sure to leave the classes as is, incase they're being used in other parts of the project. I added type attribute for all button elements and role="button" for buttons that do not use the button html element. A thought that crossed my mind was to change the divs to actual buttons and unstyle them so the classes can style them correctly.

Checks

No visual changes

  • [x] Check if any open issues are related to this PR; if so, be sure to tag them below. #4857
  • [x] Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • [x] Make sure to include your GitHub username inside parentheses at the end of the PR title

Related #4859 Closes #4857

plbstl avatar Feb 24 '24 16:02 plbstl