monkeytype icon indicating copy to clipboard operation
monkeytype copied to clipboard

feat(theme): added anti_hero theme (mizaagi)

Open mizaagi opened this issue 1 year ago • 20 comments

Description

  • Added anti_hero.css
  • Updated _list.json with anti_hero theme

Screenshot 2024-02-14 143657

mizaagi avatar Feb 07 '24 23:02 mizaagi

i should have called this stupid theme dragonfruit and not anti hero :( miodec if u add pls change name :)

mizaagi avatar Feb 07 '24 23:02 mizaagi

You can open the web editor with. and change your file names there, then commit.

Miodec avatar Feb 08 '24 10:02 Miodec

But also i would increase the difference between text color and sub color, they blend in a bit.

Miodec avatar Feb 08 '24 10:02 Miodec

Can you send some screenshots from the updated version?

Miodec avatar Feb 08 '24 13:02 Miodec

Can you send some screenshots from the updated version?

Added these :)

mizaagi avatar Feb 08 '24 16:02 mizaagi

I would update the text color to be closer to white, and the sub alt color to be closer to the background (darker)

This doesnt look good to me at the moment: image

Miodec avatar Feb 08 '24 17:02 Miodec

image Also error is unreadable (pro is misspelled here)

Miodec avatar Feb 08 '24 17:02 Miodec

@Miodec I fixed everything! Pretty sure that the commits I made updated, but if not then they're definitely on mizaagi:master. Thanks and sorry for the inconvenience!

mizaagi avatar Feb 08 '24 17:02 mizaagi

@Miodec just checking in... sorry for bothering you again but wanted to make sure you knew the theme was all done. thanks

mizaagi avatar Feb 09 '24 18:02 mizaagi

image image image

With flip test colors off the errors are still not visible. Difference between main and sub color is not big enough, blends together

Miodec avatar Feb 12 '24 11:02 Miodec

K

mizaagi avatar Feb 12 '24 13:02 mizaagi

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/7879172029

monkeytypegeorge avatar Feb 12 '24 23:02 monkeytypegeorge

@Miodec Finished another set of changes, hopefully the last. Screenshots have been updated as well as the code of _list.json and anti_hero.css. Sorry for the trouble again and thanks so much for considering my theme!

mizaagi avatar Feb 12 '24 23:02 mizaagi

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/7879208677

monkeytypegeorge avatar Feb 12 '24 23:02 monkeytypegeorge

image

Errors are still invisible

Miodec avatar Feb 13 '24 11:02 Miodec

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/7885955651

monkeytypegeorge avatar Feb 13 '24 11:02 monkeytypegeorge

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/7886010576

monkeytypegeorge avatar Feb 13 '24 11:02 monkeytypegeorge

Dude... I don't know what you mean. I've changed it multiple times. What would the optimal color be? Please send it to me

mizaagi avatar Feb 13 '24 14:02 mizaagi

Well.. something that is actually visible at a glance.

Miodec avatar Feb 13 '24 14:02 Miodec

@Miodec fixed the color

mizaagi avatar Feb 14 '24 20:02 mizaagi

This PR is stale. Please trigger a re-run of the PR check action.

github-actions[bot] avatar Feb 22 '24 20:02 github-actions[bot]

Hey @Miodec 🙏🙏🙏

mizaagi avatar Feb 25 '24 05:02 mizaagi

Hey @Miodec 🙏🙏🙏

dw bro I think it will be added in I'd use it myself

FFUV avatar Feb 25 '24 14:02 FFUV

Thank you so much!!!!! So happy

mizaagi avatar Feb 27 '24 21:02 mizaagi