monkeytype icon indicating copy to clipboard operation
monkeytype copied to clipboard

Language: Bangla, Monkeytype cannot recognize characters ড়, য়

Open Oymate opened this issue 2 years ago • 32 comments

Did you clear cache before opening an issue?

  • [X] I have cleared my cache

Is there an existing issue for this?

  • [X] I have searched the existing issues

Does the issue happen when logged in?

Yes

Does the issue happen when logged out?

Yes

Does the issue happen in incognito mode when logged in?

Yes

Does the issue happen in incognito mode when logged out?

Yes, but sometimes it didn't

Account name

sajsajrob

Account config

{"theme":"serika_dark","themeLight":"serika","themeDark":"serika_dark","autoSwitchTheme":false,"customTheme":false,"customThemeColors":["#323437","#e2b714","#e2b714","#646669","#2c2e31","#d1d0c5","#ca4754","#7e2a33","#ca4754","#7e2a33"],"favThemes":[],"showKeyTips":true,"showLiveWpm":false,"showTimerProgress":true,"smoothCaret":"medium","quickRestart":"off","punctuation":false,"numbers":false,"words":50,"time":30,"mode":"time","quoteLength":[1],"language":"bangla","fontSize":1.5,"freedomMode":false,"difficulty":"normal","blindMode":false,"quickEnd":false,"caretStyle":"default","paceCaretStyle":"default","flipTestColors":false,"layout":"default","funbox":"none","confidenceMode":"off","indicateTypos":"off","timerStyle":"mini","colorfulMode":false,"randomTheme":"off","timerColor":"main","timerOpacity":"1","stopOnError":"off","showAllLines":false,"keymapMode":"off","keymapStyle":"staggered","keymapLegendStyle":"lowercase","keymapLayout":"overrideSync","keymapShowTopRow":"layout","fontFamily":"Roboto_Mono","smoothLineScroll":false,"alwaysShowDecimalPlaces":false,"alwaysShowWordsHistory":false,"singleListCommandLine":"manual","capsLockWarning":true,"playSoundOnError":false,"playSoundOnClick":"off","soundVolume":"0.5","startGraphsAtZero":true,"showOutOfFocusWarning":true,"paceCaret":"off","paceCaretCustomSpeed":100,"repeatedPace":true,"pageWidth":"125","accountChart":["on","on","on"],"minWpm":"off","minWpmCustomSpeed":100,"highlightMode":"letter","alwaysShowCPM":false,"ads":"result","hideExtraLetters":false,"strictSpace":false,"minAcc":"off","minAccCustom":90,"showLiveAcc":false,"showLiveBurst":false,"monkey":false,"repeatQuotes":"off","oppositeShiftMode":"off","customBackground":"","customBackgroundSize":"cover","customBackgroundFilter":[0,1,1,1,1],"customLayoutfluid":"qwerty#dvorak#colemak","monkeyPowerLevel":"off","minBurst":"off","minBurstCustomSpeed":100,"burstHeatmap":false,"britishEnglish":false,"lazyMode":false,"showAverage":"off","tapeMode":"off"}

Current Behavior

Monkeytype cannot recognize the letters ড়, য় (maybe even ঢ় though I was not able to get any words that include ঢ়). I believe this happens because it uses some old encoding scheme where ড+় is used, where the correct letter would be ড়.

Expected Behavior

Monkeytype recognizes ড়, ঢ়, য়

Steps To Reproduce

  1. Go to Monkeytype
  2. Switch language to Bangla
  3. Restart words until you get words such as নয়, উড়ন্ত, পড়া, শয়ন, গাঢ় etc.
  4. Try to type these words using Linux i-bus keyboard or Windows Avro phonetic/Jatiyo keyboard.
  5. Monkeytype can't recognize characters

Environment

  • OS:Win 10, PopOS latest
  • Browser:Firefox
  • Browser Version:115.0.2

Anything else?

No response

Oymate avatar Jul 20 '23 09:07 Oymate

How do you achieve those characters? Which keys do I press?

Miodec avatar Jul 21 '23 12:07 Miodec

If you use Avro, then you can change layout by pressing F12(don't press Shift+Alt messes up keyboard on windows). Then from dropdown you can select phonetic or Jatiyo. If you select jatiyo then press P/Shift+E/Shift+P, to get these letters. On phonetic you have to type phonetically in english. Like নয় is 'noy' followed by space/enter to select dropdown text.

On Linux install Bangla(Bangladesh) Jatiyo Layout and with Windows key+Space switch keyboard and type P/Shift+E/Shift+P.

Or the simplest solution for you, copy paste from unicode block https://symbl.cc/en/unicode/blocks/bengali/#Additional_consonants in additional consonant section.

Oymate avatar Jul 21 '23 17:07 Oymate

image image image

Which one is best? Which keys do i press then? Which ones are broken?

Miodec avatar Jul 25 '23 10:07 Miodec

Can you send screenshot of the first two option in 'Shift' mode? Thanks

Oymate avatar Jul 27 '23 11:07 Oymate

BTW, which app are you using? I might be able to give clearer response if I know.

Oymate avatar Jul 27 '23 11:07 Oymate

Thats just the MacOS layout selector

Miodec avatar Jul 27 '23 11:07 Miodec

Ok, the second layout is MS InScript layout. In order to get ড়,ঢ়,য়

  • Press Alt+Opening Square bracket/third bracket(ড়)
  • Press Alt+Shift+Opening Square bracket/third bracket(ঢ়)
  • Press Shift+?(য়)

Oymate avatar Jul 27 '23 12:07 Oymate

So, for some reason calling .normalize() on the gives us this result: image Even though it should return a normalized, composed form of a given string (so, without breaking apart the characters)

Then, because of the way monkeytype handles input, these are split into separate elements, and then displayed separately image

I could add a special case to NOT normalize Bangla characters, but there still exists the issue of the separate characters. Bangla seems to be the only language (that i've encountered so far) that displays different characters (if surrounded by other characters) while not actually modifying them

image

Monkeytype requires splitting characters to provide per character feedback on if the key was pressed correctly or not

image

This honestly might be impossible to fix, unless there exists a font which wil not display these dotted circles: image

Miodec avatar Jul 27 '23 15:07 Miodec

I would like to remind you that কিিি is intended rendering while ক ি ি ি ি ি is not. The reason ড় gets split might be because in previous(like 90's) version of unicode there was no ড়, ড and the fota was combined to get the letter. Subsequent application brought in the character ড়। When you do implement changes related to this case please give me screenshots as example so I can assure you it is correct.

Oymate avatar Jul 28 '23 10:07 Oymate

I understand the separate rendering is not intended. I also said that there is no way around it without completely reworking the website and straight up removing one of the main features (whch is per key highlight)

Miodec avatar Jul 28 '23 10:07 Miodec

Actually the per key highlight works as intended and expected for other words and characters.

Oymate avatar Jul 28 '23 10:07 Oymate

It doesn't. When you go to zen mode and type anything, no characters get connected. image

Miodec avatar Jul 28 '23 10:07 Miodec

Wait is zen deployed or in testing?

Oymate avatar Jul 28 '23 10:07 Oymate

Zen is live

Miodec avatar Jul 28 '23 10:07 Miodec

Interesting, it works in normal mode but not zen mode. In normal mode characters after the main letter are highlighted properly while characters before the main letter are not. Is it possible to implement this, page 70 glyph colouring?

Oymate avatar Jul 28 '23 11:07 Oymate

If it's not possible to fix these without breaking changes, just implement proper input normalization for ড়,ঢ় and য় , I will forgo Zen mode no problem.

Oymate avatar Jul 28 '23 11:07 Oymate

Nevermind, i was wrong. These characters are displayed correctly if you just switch the language to bangla.. image

Miodec avatar Jul 28 '23 11:07 Miodec

Alright, well... going full circle, how do i type উড়ন্ত ? Which keys do i press? Because so far i can type ড় and it gets recognised

Miodec avatar Jul 28 '23 11:07 Miodec

উড়ন্ত Shift+G, Alt+[, V, D, L (v means small v, similar for d and l)

Oymate avatar Jul 28 '23 13:07 Oymate

image

Looks to be working correctly for me

Miodec avatar Jul 28 '23 13:07 Miodec

Did you use custom text mode? Custom works but not normal typing mode.

Oymate avatar Jul 28 '23 14:07 Oymate

Yeah i did. Interesting, let me play around.

Miodec avatar Jul 28 '23 14:07 Miodec

Test on Time>Bangla>120s for testing time. Restart until a word with ড়, ঢ়, য়, ঐ, ঔ comes, tell me the word. I will provide the keys than you can type it in with restart.

Oymate avatar Jul 28 '23 15:07 Oymate

I have the same problem, I couldn't get how you guys fixed it. image

mm-crj avatar Sep 26 '23 15:09 mm-crj

I think i found a solution, ill deploy it to the live site later today - please test and let me know.

Miodec avatar Oct 02 '23 15:10 Miodec

I tested it for the letter 'য়' that works, but I will check the other characters like it and let you know. However, there is another issue that I would like to draw your attention to here.

mm-crj avatar Oct 03 '23 13:10 mm-crj

I think it is kind of working, but it detects something after the letter য়. So each time, I have to backspace before typing forward. And it seems to occur in time mode with 60s.

mm-crj avatar Oct 05 '23 11:10 mm-crj

How do you type that problematic letter?

Miodec avatar Oct 06 '23 11:10 Miodec

I am on ubuntu, I use the Baisakhi layout image then its shift+y.

mm-crj avatar Oct 06 '23 11:10 mm-crj

Seems like im getting a different character when pressing shift+y. Which keys is on this layout?

image

Miodec avatar Oct 09 '23 11:10 Miodec