monkeytype icon indicating copy to clipboard operation
monkeytype copied to clipboard

Tape mode + Smooth line scroll + enter

Open KorolOrol opened this issue 2 years ago • 8 comments

Did you clear cache before opening an issue?

  • [X] I have cleared my cache

Is there an existing issue for this?

  • [X] I have searched the existing issues

Does the issue happen when logged in?

Yes

Does the issue happen when logged out?

Yes

Does the issue happen in incognito mode when logged in?

Yes

Does the issue happen in incognito mode when logged out?

Yes

Account name

KorolOrol

Account config

{"theme":"dev","themeLight":"serika","themeDark":"serika_dark","autoSwitchTheme":false,"customTheme":false,"customThemeColors":["#323437","#e2b714","#e2b714","#646669","#2c2e31","#d1d0c5","#ca4754","#7e2a33","#ca4754","#7e2a33"],"favThemes":[],"showKeyTips":true,"showLiveWpm":false,"showTimerProgress":true,"smoothCaret":true,"quickRestart":"off","punctuation":false,"numbers":false,"words":50,"time":60,"mode":"custom","quoteLength":[1],"language":"english","fontSize":1.5,"freedomMode":false,"difficulty":"normal","blindMode":false,"quickEnd":false,"caretStyle":"default","paceCaretStyle":"default","flipTestColors":false,"layout":"default","funbox":"none","confidenceMode":"off","indicateTypos":"off","timerStyle":"mini","colorfulMode":false,"randomTheme":"off","timerColor":"main","timerOpacity":"1","stopOnError":"off","showAllLines":false,"keymapMode":"off","keymapStyle":"staggered","keymapLegendStyle":"lowercase","keymapLayout":"overrideSync","keymapShowTopRow":"layout","fontFamily":"Cascadia_Code","smoothLineScroll":true,"alwaysShowDecimalPlaces":false,"alwaysShowWordsHistory":false,"singleListCommandLine":"manual","capsLockWarning":true,"playSoundOnError":false,"playSoundOnClick":"off","soundVolume":"0.5","startGraphsAtZero":true,"showOutOfFocusWarning":true,"paceCaret":"off","paceCaretCustomSpeed":100,"repeatedPace":true,"pageWidth":"125","chartAccuracy":false,"chartStyle":"line","minWpm":"off","minWpmCustomSpeed":100,"highlightMode":"letter","alwaysShowCPM":true,"ads":"off","hideExtraLetters":false,"strictSpace":false,"minAcc":"off","minAccCustom":90,"showLiveAcc":false,"showLiveBurst":false,"monkey":false,"repeatQuotes":"off","oppositeShiftMode":"off","customBackground":"","customBackgroundSize":"cover","customBackgroundFilter":[0,1,1,1,1],"customLayoutfluid":"qwerty#dvorak#colemak","monkeyPowerLevel":"off","minBurst":"off","minBurstCustomSpeed":100,"burstHeatmap":false,"britishEnglish":false,"lazyMode":false,"showAverage":"off","tapeMode":"letter"}

Current Behavior

When the tape mode is on and enter occurs in the text, the next line appears below the screen and is not visible. image

Expected Behavior

The next line will follow the previous one, or the previous line will disappear and a new one will appear.

Steps To Reproduce

  1. Tunt "Tape mode" to "letter" or "word"
  2. Turn "Smooth line scroll" to on
  3. Type text with enters.

Environment

  • OS: Windows 11
  • Browser: Microsoft Edge
  • Browser Version: 108.0.1462.76 (Official Build) (64-bit)

Anything else?

No response

KorolOrol avatar Jan 11 '23 11:01 KorolOrol

Side effect of the way tape mode is implemented. I could show the next line but it would "stick" to the one above: Screenshot 2023-01-11 at 13 27 46 Screenshot 2023-01-11 at 13 27 38 Screenshot 2023-01-11 at 13 28 24

Maybe I could only do it if there is a new line in the text, but still, not sure if I like how it looks.

Miodec avatar Jan 11 '23 12:01 Miodec

I want to work on this, I can make it like this: Screenshot 2023-05-31 at 10 13 12 AM

harshkanjariya avatar May 31 '23 04:05 harshkanjariya

I want to work on this, I can make it like this: Screenshot 2023-05-31 at 10 13 12 AM

It doesnt really make sense for the enter character to be there while keeping the text in the same line.

Miodec avatar Jun 01 '23 11:06 Miodec

@Miodec Would it be possible to have the new line but offset it like this? And have it fade in the closer you get like everything else. image

Ferotiq avatar Aug 20 '23 18:08 Ferotiq

@Miodec Would it be possible to have the newline but offset it like this? And have the newline fade in the closer you get like everything else. image

This could work. Not sure how difficult it would be to implement.

Miodec avatar Aug 21 '23 09:08 Miodec

@Miodec i can try, probably easy to implement

harshkanjariya avatar Aug 22 '23 10:08 harshkanjariya

@Miodec i can try, probably easy to implement

Alright, assigned.

Miodec avatar Aug 22 '23 10:08 Miodec

@Miodec PR ready for review: #4969

ikarofelix avatar Mar 07 '24 14:03 ikarofelix