monkeytype
monkeytype copied to clipboard
monkeytypegame
Multiple funboxes
Closes #3547 and closes #487
Some assistance needed:
- [x] includes("read_ahead") return true, when "read_ahead_easy" or hard is included
- [ ] Keymap not adapts to 58008 and arrows funboxes
- [x] modeSaved is uninitialized after page refreshing
- [ ] Command line
This flaws are demonstrated in video (style + script is fixed)
https://user-images.githubusercontent.com/42677093/191580005-36bdf76c-a168-4309-86ae-0aaf7534bad0.mp4
Who would perform arrows + choo choo?
The PR check action failed. Please review the logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/3100243770
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Yeah looks like the categories won't be enough - need a list of special cases that are not allowed (like that choo choo and arrows haha)
The PR check action failed. Please review the logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/3100243770
The PR check action failed. Please review the logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/3105148301
There is checkFunbox function, that checks special cases. I didn't add arrows+choo choo because it's not broken. Instead of absolute direction, player should input direction related on previous. I got 5 wpm. If you really mind, I will add an this exception
How does includes function works? Is there an alternative that's picking exact match?
There is checkFunbox function, that checks special cases. I didn't add arrows+choo choo because it's not broken. Instead of absolute direction, player should input direction related on previous. I got 5 wpm. If you really mind, I will add an this exception
Its not broken, but its also pretty much pure luck - please add it as an exception.
How does includes function works? Is there an alternative that's picking exact match?
Includes checks if the parameter is inside a function.
Also if you wanna chat in real time about this PR join our discord server (discord.gg/monkeytype) and message in the #development channel.
The PR check action failed. Please review the logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/3213531963
The PR check action failed. Please review the logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/3247797373
The PR check action failed. Please review the logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/3247795363
I'm stuck with resolving circular imports and list duplication. Command line entity works as buggy as tags entity, but works. Could you help?
Imports:
- config.ts - funbox.ts
- settings.ts - funbox.ts
Duplication:
frontend/src/ts/test/funbox.ts:Funboxes has every property frontend/static/funbox/_list.json has.
The PR check action failed. Please review the logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/3274541751
The PR check action failed. Please review the logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/3299808876
The PR check action failed. Please review the logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/3347076884
The PR check action failed. Please review the logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/3347079674
The PR check action failed. Please review the logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/3430566565
The PR check action failed. Please review the logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/3439282512
The PR check action failed. Please review the logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/3488713919
The PR check action failed. Please review the logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/3490202192