monkeytype icon indicating copy to clipboard operation
monkeytype copied to clipboard

Screenshot is not taken wide enough

Open oof2win2 opened this issue 3 years ago • 18 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

Did you clear cache before opening an issue?

  • [X] I have cleared my cache

Current Behavior

The screenshot button takes a screenshot that is not of the correct width, which removes a part of the content on the right and looks bad.

image

Expected Behavior

I would expect the screenshot to be of the correct width and capture all of the content.

Steps To Reproduce

  1. Complete a test
  2. Attempt to create a screenshot
  3. Paste the screenshot somewhere to observe it

Environment

  • OS: MacOS 11.4
  • Browser: Chrome
  • Browser Version: Version 95.0.4638.54 (Official Build) (x86_64)

Anything else?

No response

Did you check incognito mode?

  • [ ] I have checked incognito mode

Config

No response

oof2win2 avatar Nov 02 '21 14:11 oof2win2

I can't seem to reproduce. Does it happen on every test?

Miodec avatar Nov 05 '21 15:11 Miodec

Yes, it seems to be so. Even on incognito mode, 15s: https://imgur.com/a/XTmFvdu

oof2win2 avatar Nov 05 '21 16:11 oof2win2

Is your zoom level at 100%? Did you change your browser font size settings?

Miodec avatar Nov 07 '21 22:11 Miodec

I did not change my font size and my zoom level is at 100%.

oof2win2 avatar Nov 09 '21 13:11 oof2win2

Please paste in your config then, because i cant reproduce this.

Miodec avatar Nov 09 '21 15:11 Miodec

I assume that you requested the MonkeyType config.

{"theme":"80s_after_dark","customTheme":true,"customThemeColors":["#1b1d36","#fca6d1","#99d6ea","#99d6ea","#fca6d1","#fffb85","#fffb85","#fffb85","#fffb85"],"favThemes":["80s_after_dark"],"showKeyTips":false,"showLiveWpm":true,"showTimerProgress":true,"smoothCaret":true,"quickTab":false,"punctuation":false,"numbers":false,"words":25,"time":60,"mode":"words","quoteLength":[0],"language":"english","fontSize":15,"freedomMode":true,"difficulty":"normal","blindMode":false,"quickEnd":false,"caretStyle":"default","paceCaretStyle":"default","flipTestColors":false,"layout":"default","funbox":"none","confidenceMode":"off","indicateTypos":false,"timerStyle":"mini","colorfulMode":false,"randomTheme":"off","timerColor":"text","timerOpacity":"1","stopOnError":"off","showAllLines":false,"keymapMode":"off","keymapStyle":"staggered","keymapLegendStyle":"lowercase","keymapLayout":"overrideSync","fontFamily":"Roboto_Mono","smoothLineScroll":true,"alwaysShowDecimalPlaces":false,"alwaysShowWordsHistory":true,"singleListCommandLine":"manual","playSoundOnError":false,"playSoundOnClick":"off","startGraphsAtZero":true,"swapEscAndTab":false,"showOutOfFocusWarning":true,"paceCaret":"custom","paceCaretCustomSpeed":"65","repeatedPace":true,"pageWidth":"100","chartAccuracy":true,"chartStyle":"line","minWpm":"off","minWpmCustomSpeed":"65","highlightMode":"letter","alwaysShowCPM":false,"enableAds":"off","hideExtraLetters":false,"strictSpace":false,"minAcc":"off","minAccCustom":90,"showLiveAcc":false,"showLiveBurst":false,"monkey":false,"repeatQuotes":"off","oppositeShiftMode":"off","customBackground":"","customBackgroundSize":"cover","customBackgroundFilter":[0,1,1,1,1],"customLayoutfluid":"qwerty","monkeyPowerLevel":"off","minBurst":"off","minBurstCustomSpeed":100,"burstHeatmap":true,"britishEnglish":false,"lazyMode":false}

oof2win2 avatar Nov 09 '21 19:11 oof2win2

Can confirm that happens with my settings too.

brneor avatar Dec 21 '21 12:12 brneor

Could you guys get a screen recording of this? This has to be something super specific.

Miodec avatar Dec 21 '21 13:12 Miodec

https://user-images.githubusercontent.com/23482862/146941968-c38a727d-4b58-4a5c-8512-3a28bac3940d.mov

image

Above is the screen recording and the resultant image.

oof2win2 avatar Dec 21 '21 13:12 oof2win2

Just something I noticed, in the video provided above it shows a scroll bar on the right side. Could this simply be offsetting the results screen?

CameronCT avatar Dec 28 '21 19:12 CameronCT

Scrollbar wouldnt cause that much to be cut off.

Also just did a test and the screenshot was fine with the scrollbar (at least for me)

Miodec avatar Dec 28 '21 20:12 Miodec

Hey, I managed to reproduce this in Firefox. It happens on seemingly random occasions. The image size is always the same, with only the content stretching outside of it on the X axis. After some research, I believe it's caused by a bug html2canvas. I have managed to code up a temporary workaround which just consists of increasing the padding. It patches the bug in most cases, without making the screenshot look weird for those that are not experiencing the bug.

bragefuglseth avatar Jan 04 '22 20:01 bragefuglseth

Reopening since im not 100% sure the PR is a definite fix.

Deployed a new version, clear cache and test again.

Miodec avatar Jan 04 '22 22:01 Miodec

It works on dev for me. I assume prod not yet, since it's not a definite one?

oof2win2 avatar Jan 05 '22 07:01 oof2win2

It is live already

Miodec avatar Jan 12 '22 20:01 Miodec

Works for me (bad score so meh)!

image

oof2win2 avatar Jan 12 '22 21:01 oof2win2

image

Nugget1308 avatar Jan 20 '22 14:01 Nugget1308

Is anybody still experiencing this issue with the fix?

Ferotiq avatar Mar 05 '22 17:03 Ferotiq