MBINCompiler icon indicating copy to clipboard operation
MBINCompiler copied to clipboard

Lossy Floating-Point Serialization

Open GaticusHax opened this issue 5 years ago • 2 comments

Round-trip serialization of floating point values should be identical (lossless).

When an MBIN file is converted to EXML and floating-point values are serialized into strings, the full-precision of the value is not preserved. When the EXML is then converted back to an MBIN file, the floating-point values may not match the original MBIN file.

While the loss of precision does not critically impact the game data, it makes comparing files difficult.

GaticusHax avatar Oct 13 '19 07:10 GaticusHax

did you not fix this in 7843f9dee50f372cdf4c1d28fd515438e9c0a18e ?

monkeyman192 avatar Oct 13 '19 12:10 monkeyman192

I did. This issue is mostly just to compliment the others in the Lossiness milestone. I will do another round of testing before I close this though.

GaticusHax avatar Oct 13 '19 17:10 GaticusHax