FireShort
FireShort copied to clipboard
implemented code splitting
I have implemented react code splitting
closes #168
Thanks for opening this pull request 🎉🎉! Please check out our contributing guidelines and provide us atleast 24 hours to review this PR
I am a DWOC participant. Please consider labelling my PR for DWOC
@pranab2021 thank you for the PR, on running your PR, I haven't found any increase in speed yet, looks like you have not yet implemented code splitting properly yet, also please look at these images below, the UI has been messed up by your code:
oh, i didnt notice that. I will try to solve it
Hi @monizb, I have resolved UI issue. The loader is now removed from Home and put in App.js Suspense fallback.
I Hope everything is working fine. If any issue is there request for changes😁
I am sorry i took too much time. I was looking through the codebase to find how things are working
UI after this commit:--

Hi @monizb, I have resolved UI issue. The loader is now removed from Home and put in App.js Suspense fallback.
I Hope everything is working fine. If any issue is there request for changes😁
I am sorry i took too much time. I was looking through the codebase to find how things are working
UI after this commit:--
Hey! Sure give me some time and ill check this out today :)
@pranab2021 I am still able to see the following page:

okay.. i will see about that
This PR seems to have gone stale, adding label accordingly