FireShort icon indicating copy to clipboard operation
FireShort copied to clipboard

implemented code splitting

Open pranab2021 opened this issue 4 years ago • 8 comments

I have implemented react code splitting

closes #168

pranab2021 avatar Jan 19 '21 17:01 pranab2021

Thanks for opening this pull request 🎉🎉! Please check out our contributing guidelines and provide us atleast 24 hours to review this PR

boring-cyborg[bot] avatar Jan 19 '21 17:01 boring-cyborg[bot]

I am a DWOC participant. Please consider labelling my PR for DWOC

pranab2021 avatar Jan 19 '21 17:01 pranab2021

@pranab2021 thank you for the PR, on running your PR, I haven't found any increase in speed yet, looks like you have not yet implemented code splitting properly yet, also please look at these images below, the UI has been messed up by your code:

Screenshot 2021-01-20 at 10 53 12 AM Screenshot 2021-01-20 at 10 53 41 AM

monizb avatar Jan 21 '21 16:01 monizb

oh, i didnt notice that. I will try to solve it

pranab2021 avatar Jan 21 '21 16:01 pranab2021

Hi @monizb, I have resolved UI issue. The loader is now removed from Home and put in App.js Suspense fallback.

I Hope everything is working fine. If any issue is there request for changes😁

I am sorry i took too much time. I was looking through the codebase to find how things are working

UI after this commit:-- image

pranab2021 avatar Jan 30 '21 08:01 pranab2021

Hi @monizb, I have resolved UI issue. The loader is now removed from Home and put in App.js Suspense fallback.

I Hope everything is working fine. If any issue is there request for changes😁

I am sorry i took too much time. I was looking through the codebase to find how things are working

UI after this commit:-- image

Hey! Sure give me some time and ill check this out today :)

monizb avatar Feb 01 '21 05:02 monizb

@pranab2021 I am still able to see the following page:
Screenshot 2021-02-01 at 10 58 46 AM

monizb avatar Feb 01 '21 05:02 monizb

okay.. i will see about that

pranab2021 avatar Feb 04 '21 04:02 pranab2021

This PR seems to have gone stale, adding label accordingly

github-actions[bot] avatar Feb 18 '23 02:02 github-actions[bot]