FireShort icon indicating copy to clipboard operation
FireShort copied to clipboard

Published 20 hours ago • verified publisher icon monizb

Show a Dialog after each link is created

Open paultech4u opened this issue 5 years ago • 8 comments
trafficstars

What is the current behavior?

"
  • [ ] Implements a share button to share URL.
  • [ ] Implements a QR Code scan.
  • [ ] JPG image sharing not fixed.

What is the new behavior?

  1. When the URL card is created show the share dialog. chrome-capture (1)
  2. Added a share button to the card for sharing the URL. chrome-capture

paultech4u avatar Oct 06 '20 11:10 paultech4u

Thanks for opening this pull request 🎉🎉! Please check out our contributing guidelines and provide us atleast 24 hours to review this PR

boring-cyborg[bot] avatar Oct 06 '20 11:10 boring-cyborg[bot]

@paultech4u thank you soo much for the PR! 🥳🥳🥳 Can you please make it so that the dialog box has the short url (only the code) part in bold in the centre above the sharing options with the copy button on the right of the short url and when clicked it should automatically take the current domain, like it already does and shows a small message that it has been copied :) Also there are a lot of conflicts in your PR with the master branch, I request you to pull in all the latest changes and test the url sharing again and then commit.

Edit: The twitter option seems to be taking the long URL in the tweet rather than the short URL. The Facebook and Email Share doesnt seem to be working as expected, please check it out :)

Edit2: The Share Box appears as soon as click shorten URL, whether or not the link has been created, for example if I enter the same short URL which already exists, it gives me a warning, but the Share URL box still appears overlapping the warning
Screenshot 2020-10-06 at 6 44 06 PM

monizb avatar Oct 06 '20 13:10 monizb

The short URL is the same as the custom URL the problem now is that the short URL is not a valid URL I don't know if you are aware of these chrome-capture issues.

paultech4u avatar Oct 08 '20 16:10 paultech4u

@paultech4u I didn't get you there, you mean if i enter the long url in the short url as well, its not valid? Because the screenshot shown only material in short URL

monizb avatar Oct 08 '20 16:10 monizb

@monizb I have resolved all the conflict in my branch please do check it.

paultech4u avatar Oct 12 '20 18:10 paultech4u

@paultech4u still looks like you have many conflicts, please rectifiy them im adding the accepted label as of now

monizb avatar Oct 16 '20 05:10 monizb

@monizb I have resolved the issues.

paultech4u avatar Oct 16 '20 12:10 paultech4u

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Dec 15 '20 12:12 stale[bot]

This PR seems to have gone stale, adding label accordingly

github-actions[bot] avatar Feb 19 '23 02:02 github-actions[bot]