old_mobile_app icon indicating copy to clipboard operation
old_mobile_app copied to clipboard

feat: 1Password integration for iOS

Open webwelten opened this issue 6 years ago • 6 comments

Add 1Password to login screen

  • Put an image/icon provided by 1password at the end of the password input.
  • Integrate the plugin and provide the required function on iOS.

I would highly appreciate your feedback on the changes I've made. Not sure if your prefer a new TextInput component with an InlineImage and are the handlers at the right spot (LoginForm.tsx)?

https://github.com/monicahq/chandler/issues/54

webwelten avatar Jun 18 '18 16:06 webwelten

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jun 18 '18 16:06 CLAassistant

@webwelten,

Thanks, this is awesome !

I'm not concerned that much about handlers location for now (we could place the onepasswordSupported state in redux).

The issue is that in my case, one password is not supported (one password app is set up on my phone). Any idea why ?

Could you show me a screenshot of the input please ?

Mokto avatar Jun 24 '18 13:06 Mokto

Alright, I haven't worked with podfiles before so I guess I made a mistake there. I was able to build and run the app correctly with the .xcodeproj-file.

Having changed to Monica.xcworkspace instead, xcode wouldn't build the correct version. Do I have to pull the changes somehow or do something to make them appear in the .xworkspace as well?

webwelten avatar Jun 27 '18 21:06 webwelten

You might need to run react-native link from the root of the project.

Mokto avatar Jul 10 '18 02:07 Mokto

Thanks I'll try it when I can !

Mokto avatar Aug 01 '18 02:08 Mokto

I'll have to check one thing first, before you're doing the work. I'll tell you

webwelten avatar Aug 01 '18 13:08 webwelten