monica Birthday of someone who's birthday is today is not shown on the dashboard

Birthday of someone who's birthday is today is not shown on the dashboard

Open rickpastoor opened this issue 7 years ago • 15 comments

I have a contact who's birthday is today, but it is not shown, while others (further in the future) are shown. I think it is useful to see who's birthdays I actually have to do something about -- today ;)

Jan 21 '18 13:01 rickpastoor

Fully agree on that and I think this can be merged with #740

Feb 26 '18 09:02 tlwt

Feedback from user:

One thing i've noticed is that my dashboard only shows upcoming reminders and not current ones (i.e. reminders for today)

Mar 02 '18 01:03 djaiss

I have hard time reproducing this bug. The thing is, the dashboard lists all reminders in the current month (regardless of the day we are in the current month).

Do you have any other details?

Mar 02 '18 01:03 djaiss

I just double checked - birthday from March 01st is not shown anymore in dashboard. I am no expert but suppose that the error may be somewhere here:

Once a reminder is passed, the next_expected_date is moved. In my case from 01.03.2018 to 01.03.2019. Therefore it is not showing up anymore in the dashboard, as it not between 01.03.2018 and 31.03.2018 anymore.

https://github.com/monicahq/monica/blob/8d2b21a0ce768f67342dcffca628b436a1fbfab7/app/Account.php#L531

Mar 02 '18 07:03 tlwt

🤦‍♂️

Damn, of course. How come I didn't see that. Sorry about this, it's definitely a bug, will fix it.

Mar 02 '18 12:03 djaiss

Ping! I keep missing things because of this :(

Dec 10 '18 15:12 rickpastoor

Ok. I'm on it!

Dec 12 '18 14:12 djaiss

This seems to be an issue still, sorry for brining it up again :)

Apr 23 '19 06:04 rickpastoor

This seems to be an issue still, sorry for brining it up again :) [2]