monica icon indicating copy to clipboard operation
monica copied to clipboard

Published 20 hours ago • verified publisher icon monicahq

feat: add LDAP import command to artisan

Open epsilon-0 opened this issue 2 years ago • 2 comments

Signed-off-by: Aisha Tammy [email protected]

Checklist

Before submitting the PR

  • [x] Read the CONTRIBUTING document before submitting your PR.
  • [x] If the PR is related to an issue or fix one, don't forget to indicate it.
  • [x] Create your PR as draft if it is not final yet. Mark it as ready... when it’s ready. Otherwise the PR will be considered complete and rejected if it's not working.

General checks

  • [x] Make sure that the change you propose is the smallest possible.
  • [x] The name of the PR should follow the conventional commits guideline that the project follows.

Backend/models changes

  • [ ] The API has been updated.
  • [ ] API's documentation has been added by submitting a pull request in the marketing website repository.
  • [ ] Tests have been added for the new code.
  • [ ] If you change a model, make sure the SetupTest file is updated. We need seeders to develop locally and generate fake data.

If the code changes the SQL schema

  • [ ] Make sure exporting account data as SQL is still working.
  • [ ] Make sure your changes do not break importing data with vCard and .csv files.
  • [ ] Make sure account reset and deletion still work.

Other tasks

  • [ ] CONTRIBUTORS entry added, if necessary.
  • [ ] If it's relevant and worth mentioning, create a changelog entry for this change. The changelog entry will appear inside the UI for all users to see. To know if your change is worth the creation of a changelog entry, read the documentation.
  • [ ] Don't forget to ask for a free account on https://monicahq.com as anyone who contributes can request a free account.

epsilon-0 avatar May 24 '22 17:05 epsilon-0

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar May 24 '22 17:05 CLAassistant

Is there anyway I can help get this pushed forward ?

epsilon-0 avatar Jun 21 '22 23:06 epsilon-0

@epsilon-0 I did not test it, however I don't think it can do any harm, so I'm ok with it :)

asbiin avatar Oct 31 '23 10:10 asbiin

Haha, I agree it doesn't seem like it will do any harm. I've recently found out about the laravel ldap record - https://github.com/DirectoryTree/LdapRecord-Laravel - which would be the ideal way to implement this. I'll look into doing that enhancement soon :)

epsilon-0 avatar Nov 02 '23 04:11 epsilon-0