mongodb
fix(NODE-7291): update moduleResolution to adhere to TS6 deprecation
Description
Summary of Changes
This updates the moduleResolution config property according to https://www.typescriptlang.org/tsconfig/#moduleResolution, as TS6 deprecated "node"
Note that I have not updated the tsd moduleResolutuion since I'm unsure whether it is following TS's footsteps on this matter. If it should also be updated, I will update it
Notes for Reviewers
What is the motivation for this change?
TS has deprecated the "node" moduleResolution, and now it sends errors in the console, hurting DX:
Double check the following
- [x] Lint is passing (
npm run check:lint) - [x] Self-review completed using the steps outlined here
- [x] PR title follows the correct format:
type(NODE-xxxx)[!]: description- Example:
feat(NODE-1234)!: rewriting everything in coffeescript
- Example:
- [x] Changes are covered by tests
- [ ] New TODOs have a related JIRA ticket
Hi @GalacticHypernova thanks so much for all your work on this PR. We're currently reviewing this and will get back to you soon.
@GalacticHypernova Out of curiosity, how exactly are you seeing this compiler error?
Compiling a project that depends on the driver wouldn't compile the driver, so I'm not sure how you're seeing the TSC error from our tsconfig. Are you attempting to compile our driver source?
Hey! I am also unsure of how I am found this issue. I am not trying to compile the driver source, but I did notice it in a local app I use for development and production previews.
I'm assuming this can be achieved with a very specific app-level tsconfig (my app has the strictest error reporting threshold for quality assurance), or perhaps that TS-origianted errors (maybe particularly related to deprecations) are handled differently, but I can test it to be sure and report back to you